You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/04 17:13:41 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2633: [Bug][e2e] the e2e exec error in win10, fix path separator
TyrantLucifer commented on code in PR #2633:
URL: https://github.com/apache/incubator-seatunnel/pull/2633#discussion_r962342050
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/spark/SparkContainer.java:
##########
@@ -97,7 +97,8 @@ public Container.ExecResult executeSeaTunnelSparkJob(String confFile) throws IOE
// Running IT use cases under Windows requires replacing \ with /
String conf = targetConfInContainer.replaceAll("\\\\", "/");
final List<String> command = new ArrayList<>();
- command.add(Paths.get(SEATUNNEL_HOME, "bin", SEATUNNEL_SPARK_BIN).toString());
+ String sparkSh = Paths.get(SEATUNNEL_HOME, "bin", SEATUNNEL_SPARK_BIN).toString();
Review Comment:
How about change these code to
```java
String sparkBinPath = Paths.get(SEATUNNEL_HOME, "bin", SEATUNNEL_SPARK_BIN).toString()
.replaceAll("\\\\", "/");
command.add(sparkBinPath);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org