You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/10/23 20:54:55 UTC
[PR] THRIFT-6452: Pass glong values to the remainingmessagesize properties [thrift]
slachiewicz opened a new pull request, #4047:
URL: https://github.com/apache/thrift/pull/4047
The `remainingmessagesize` and `knowmessagesize` properties are `glong`, but the accepted socket and the read-check tests passed an `int` through `g_object_new`'s varargs. On aarch64, GLib then rejects the value as out of range, and three read-check tests fail on master.
Verified: `make -C lib/c_glib/test check-am` in arm64 ubuntu:22.04 → master 3 of 32 fail, this branch all 32 pass. Not run on x86_64, where the bug does not show.
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit?
- [x] Did you do your best to avoid breaking changes? No API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6452: Pass glong values to the remainingmessagesize properties [thrift]
Posted by "Jens-G (via GitHub) via notifications" <no...@thrift.apache.org>.
Jens-G commented on PR #4047:
URL: https://github.com/apache/thrift/pull/4047#issuecomment-6602921368
### Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org