You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mingdaoy (via GitHub)" <gi...@apache.org> on 2025/03/05 15:50:23 UTC
[PR] MINOR: KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
mingdaoy opened a new pull request, #19119:
URL: https://github.com/apache/kafka/pull/19119
https://github.com/apache/kafka/pull/19097#discussion_r1981526593
Result:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991430908
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I would use the following:
> 2. Clients (including Streams and Connect) must be on version 2.1 or higher before upgrading to 4.0. Many deprecated APIs were removed in Kafka 4.0. For more information about the compatibility, please refer to the compatibility matrix (link it) or KIP-1124 for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990129358
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
@dajac Sounds great!
Do I need to make changes to the current title, and pave the way for the future?
```suggestion
<h4><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.</a></h4>
```
Or, it's all good for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701364462
@mingdaoy please update your PR with trunk, you likely have a broken commit in your history (which we just reverted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991562442
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
@dajac you were one second faster than me. Thank you for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990795619
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
Yes, let's change the current title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #19119:
URL: https://github.com/apache/kafka/pull/19119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991148865
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I changed it to the following,
> For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly **from certain versions, such as 2.0 clients (or older) **, to 4.x is not feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991166491
##########
docs/upgrade.html:
##########
@@ -52,9 +73,6 @@ <h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any vers
Every <a href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java">MetadataVersion</a>
has a boolean parameter that indicates if there are metadata changes (i.e. <code>IBP_4_0_IV1(23, "4.0", "IV1", true)</code> means this version has metadata changes).
Given your current and target versions, a downgrade is only possible if there are no metadata changes in the versions between.</li>
- <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
- For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.
- </li>
</ol>
<h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4.0.0</a></h5>
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2717976372
Merged to trunk and cherry-picked to 4.0 (manually resolved the conflicts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991430908
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I would use the following:
> 2. Clients (including Streams and Connect) must be on version 2.1 or higher before upgrading to 4.0. Many deprecated APIs were removed in Kafka 4.0. For more information about the compatibility, please refer to compatibility matrix (link it) or KIP-1124 for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2716852040
@mingdaoy Would you have time for updating the PR? I'd like to merge it today as this is the last remaining change blocking the 4.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I changed it to the following,
> For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly **from certain versions, such as 2.0 clients (or older)**, to 4.x is not feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991184428
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991454625
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
@mingdaoy Do you have time for updating it? We can merge it afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990907805
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
@mingdaoy Thanks. I was perhaps not clear but I was trying to suggest a structure as follow:
```
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
<p><b>For a rolling upgrade:</b></p>
<ol>
<li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
<li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
</ol>
<h6><a id="upgrade_clients_400_notable" href="#upgrade_clients_400_notable">Notable changes in 4.0.0</a></h6>
<ul>
<li>Please see notable changes in the server section.</li>
</ul>
<h5><a id="upgrade_servers_4_0_0" href="#upgrade_servers_4_0_0">Upgrading Servers to 4.0.0 from any version 3.3.x through 3.9.x</a></h5>
<p>Note: Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, <b>broker upgrades to 4.0.0 (and higher) require KRaft mode and
the software and metadata versions must be at least 3.3.x</b> (the first version when KRaft mode was deemed production ready). For clusters in KRaft mode
with versions older than 3.3.x, we recommend upgrading to 3.9.x before upgrading to 4.0.x. Clusters in ZooKeeper mode
have to be <a href="/{{version}}/documentation.html#kraft_zk_migration">migrated to KRaft mode</a> before they can be upgraded to 4.0.x.
</p>
<p><b>For a rolling upgrade:</b></p>
....
```
We can do the same for the 4.1 section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991066599
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
@dajac pushed just now and synced with trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I changed it to the following,
> For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly **from certain versions, such as **2.0 clients (or older)**, to 4.x is not feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991554768
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
@mingdaoy I hope you don't mind but I push a small commit to tweak the text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990878073
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
@dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990996066
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991162921
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
We don't need to say what's not feasible, we should just say what's supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991054160
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
Thanks. Have you pushed the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I changed it to the following,
> For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly **from certain versions, such as 2.0 clients (or older)**, to 4.x is not feasible. **2.1 is the oldest supported version compatible with 4.0**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701424539
I have some thoughts on this, will share them later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991078954
##########
docs/upgrade.html:
##########
@@ -52,9 +73,6 @@ <h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any vers
Every <a href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java">MetadataVersion</a>
has a boolean parameter that indicates if there are metadata changes (i.e. <code>IBP_4_0_IV1(23, "4.0", "IV1", true)</code> means this version has metadata changes).
Given your current and target versions, a downgrade is only possible if there are no metadata changes in the versions between.</li>
- <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
- For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.
- </li>
</ol>
<h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4.0.0</a></h5>
Review Comment:
nit: Should we use `upgrade_servers_400_notable`?
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
I wonder whether we should call out that 2.1 is the minimum required version here KIP-896.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991164900
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain versions is not feasible.
+ For more information, please refer to <a href="https://cwiki.apache.org/confluence/x/y4kgF">KIP-1124</a>.</li>
Review Comment:
Also, "For the Kafka client upgrade path" is redundant in point 2. This whole section is about client upgrades, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.
mingdaoy commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1990997212
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
@dajac Please see above. Sorry for the wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1989645469
##########
docs/upgrade.html:
##########
@@ -19,6 +19,10 @@
<script id="upgrade-template" type="text/x-handlebars-template">
+<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4>
Review Comment:
This new section feels a bit weird because all the other section are per version. @ijuma and I discussed offline and we suggest to follow the same pattern for clients. Basically, we could have the following:
```
<h4><a id="upgrade_4_1_0" href="#upgrade_4_1_0">Upgrading Servers to 4.1.0 from any version 3.3.x through 4.0.x</a></h4>
<h4><a id="upgrade_4_1_0" href="#upgrade_clients_4_1_0">Upgrading Clients to 4.1.0</a></h4>
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
Here we keep the current content.
<h4><a id="upgrade_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0 </a></h4>
Here we adds bit about rolling upgrade clients, similarly to what we have for the servers. Moreover, we add a not about the upgrade path and link the KIP.
```
We could follow this pattern for next releases. In the future, we could also consider moving the notable changes related to the clients to the clients section but this is not necessary for 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org