You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "utafrali (via GitHub)" <gi...@apache.org> on 2026/03/13 11:58:10 UTC

[PR] Update dependencies and restore etcd API [dubbo-go]

utafrali opened a new pull request, #3245:
URL: https://github.com/apache/dubbo-go/pull/3245

   ### Description
   Fixes #3243
   
   Bumped the dependencies to newer versions. The main thing is restoring the etcd API in the client that was previously removed - it's needed for grpc compatibility.
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4059306125

   The PR checklist states "I confirm the target branch is develop", but this PR actually targets `main`. Please confirm the intended target branch — if the project convention is to merge into `develop` first, this PR should be retargeted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4059308757

   > The PR checklist states "I confirm the target branch is develop", but this PR actually targets `main`. Please confirm the intended target branch — if the project convention is to merge into `develop` first, this PR should be retargeted.
   
   I have changed the target branch to develop. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "CAICAIIs (via GitHub)" <gi...@apache.org>.
CAICAIIs commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4109734071

   Please resolve the conflict when you have time~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "utafrali (via GitHub)" <gi...@apache.org>.
utafrali commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4231896477

   @Alanxtl Thanks for pointing out that these changes should go in the [dubbogo/gost](https://github.com/dubbogo/gost) repo instead. You're right, that's the proper place for this fix. Closing this PR. Apologies for the noise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#discussion_r2934567726


##########
remoting/etcdv3/client.go:
##########
@@ -36,7 +40,7 @@ func ValidateClient(container clientFacade, opts ...gxetcd.Option) error {
 
 	// new Client
 	if container.Client() == nil {
-		newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+		newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)
 		if err != nil {

Review Comment:
   `NewClientWithOptions` is passed `context.Background()`, which can never be canceled. Since other parts of the etcdv3 remoting layer select on `client.GetCtx().Done()` (e.g., restart handler / listeners), consider creating a cancelable context tied to the container lifecycle (e.g., cancel when `container.Done()` is closed) and passing that instead so the client can reliably terminate/reconnect and avoid goroutine leaks.



##########
remoting/etcdv3/client.go:
##########
@@ -47,7 +51,7 @@ func ValidateClient(container clientFacade, opts ...gxetcd.Option) error {
 
 	// Client lose connection with etcd server
 	if container.Client().GetRawClient() == nil {
-		newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+		newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)
 		if err != nil {

Review Comment:
   Same concern here: passing `context.Background()` into `NewClientWithOptions` makes the client context non-cancelable from this layer. Please consider deriving a cancelable context (and canceling it on `container.Done()` / shutdown) so `GetCtx().Done()` can be used to stop watchers/restart loops and prevent leaks.



##########
remoting/etcdv3/client.go:
##########
@@ -68,7 +72,7 @@ func NewServiceDiscoveryClient(opts ...gxetcd.Option) *gxetcd.Client {
 		opt(options)
 	}
 
-	newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+	newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)
 	if err != nil {

Review Comment:
   `NewServiceDiscoveryClient` also hard-codes `context.Background()` for `NewClientWithOptions`, which prevents callers from propagating cancellation/deadlines into the etcd client. Consider allowing a caller-provided context (or otherwise tying cancellation to the service discovery/registry lifecycle) so internal watches can be terminated cleanly on shutdown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#discussion_r2969157995


##########
remoting/etcdv3/client.go:
##########
@@ -68,7 +72,7 @@ func NewServiceDiscoveryClient(opts ...gxetcd.Option) *gxetcd.Client {
 		opt(options)
 	}
 
-	newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+	newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)

Review Comment:
   同上,硬编码 `context.Background()`。



##########
remoting/etcdv3/client.go:
##########
@@ -47,7 +51,7 @@ func ValidateClient(container clientFacade, opts ...gxetcd.Option) error {
 
 	// Client lose connection with etcd server
 	if container.Client().GetRawClient() == nil {
-		newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+		newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)

Review Comment:
   同上,硬编码 `context.Background()`。



##########
remoting/etcdv3/client.go:
##########
@@ -36,7 +40,7 @@ func ValidateClient(container clientFacade, opts ...gxetcd.Option) error {
 
 	// new Client
 	if container.Client() == nil {
-		newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+		newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)

Review Comment:
   这里硬编码了 `context.Background()`。建议使用 `context.TODO()` 表明这是临时的,或者考虑添加一个 context 参数让调用者控制。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#discussion_r2934570991


##########
remoting/etcdv3/client.go:
##########
@@ -36,7 +40,7 @@ func ValidateClient(container clientFacade, opts ...gxetcd.Option) error {
 
 	// new Client
 	if container.Client() == nil {
-		newClient, err := gxetcd.NewClient(options.Name, options.Endpoints, options.Timeout, options.Heartbeat)
+		newClient, err := gxetcd.NewClientWithOptions(context.Background(), options)

Review Comment:
   All three `NewClientWithOptions` call sites use `context.Background()`, which creates an uncancellable context. `ValidateClient` is called under `container.ClientLock()`, so if etcd is unreachable and the dial blocks, the lock is held indefinitely — freezing the entire application.
   
   `NewClientWithOptions` internally calls `context.WithCancel(ctx)`, so cancellation from the caller side is fully supported but unused here.
   
   **Suggestion**: At minimum, use `context.WithTimeout(context.Background(), options.Timeout)` to bound the blocking time:
   ```go
   ctx, cancel := context.WithTimeout(context.Background(), options.Timeout)
   defer cancel()
   newClient, err := gxetcd.NewClientWithOptions(ctx, options)
   ```
   
   Ideally, accept a `context.Context` parameter in `ValidateClient` and `NewServiceDiscoveryClient` to give callers full control over cancellation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4064838118

   actually, what you should do is to modify https://github.com/dubbogo/gost instead of dubbo-go repo.
   The api we deleted in https://github.com/dubbogo/gost/pull/131 and added back in https://github.com/dubbogo/gost/pull/134.
   
   What you should do is to do extally the same as https://github.com/dubbogo/gost/pull/131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4199715962

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3245) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3245&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3245&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3245&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3245&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3245&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3245)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4054661914

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3245?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.97%. Comparing base ([`e7770c9`](https://app.codecov.io/gh/apache/dubbo-go/commit/e7770c9effa4ca02cb9a69c45ba1124d3325a5c6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`39cc231`](https://app.codecov.io/gh/apache/dubbo-go/commit/39cc23195764a37a3624c3430e98a8044f2a9273?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3245?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [remoting/etcdv3/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3245?src=pr&el=tree&filepath=remoting%2Fetcdv3%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #3245      +/-   ##
   ==========================================
   + Coverage   47.91%   47.97%   +0.05%     
   ==========================================
     Files         467      467              
     Lines       34045    34045              
   ==========================================
   + Hits        16314    16334      +20     
   + Misses      16407    16388      -19     
   + Partials     1324     1323       -1     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/3245?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4054590010

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3245) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3245&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3245&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3245&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3245&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3245&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3245)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "utafrali (via GitHub)" <gi...@apache.org>.
utafrali closed pull request #3245: Update dependencies and restore etcd API
URL: https://github.com/apache/dubbo-go/pull/3245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4060193594

   @CAICAIIs check this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4059306023

   `metadata/report/etcd/report.go:120` — This PR migrates `remoting/etcdv3/client.go` from `NewClient` to `NewClientWithOptions` (which supports TLS, username, password), but `metadata/report/etcd/report.go` still uses the old `NewClient` API:
   
   ```go
   client, err := gxetcd.NewClient(gxetcd.MetadataETCDV3Client, addresses, timeout, 1)
   ```
   
   This inconsistency means metadata report will not benefit from TLS/auth support, and if a future gost version removes `NewClient`, this file breaks.
   
   **Suggestion**: Update to `NewClientWithOptions` for consistency:
   ```go
   client, err := gxetcd.NewClientWithOptions(context.Background(), &gxetcd.Options{
       Name:      gxetcd.MetadataETCDV3Client,
       Endpoints: addresses,
       Timeout:   timeout,
       Heartbeat: 1,
   })
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update dependencies and restore etcd API [dubbo-go]

Posted by "utafrali (via GitHub)" <gi...@apache.org>.
utafrali commented on PR #3245:
URL: https://github.com/apache/dubbo-go/pull/3245#issuecomment-4060550539

   Done, pushed the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org