You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/04/10 15:46:27 UTC

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei opened a new issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Jonathan-Wei opened a new issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250


   **Describe the bug**
   Click to view the data source parameters in the data source list, and the type attribute is null
   
   **To Reproduce**
   Steps to reproduce the behavior, for example:
   1. Go to 'DataSource Center'
   2. Click on 'Create DataSource'
   3. Create a data source of type MySQL
   4. Return the list of data sources,click to view the data source parameters in the data source list, and the type attribute is null
   
   **Expected behavior**
   Data sources other than Oracle do not display the type attribute
   
   **Screenshots**
   ![image](https://user-images.githubusercontent.com/3073018/114275585-b7b62f80-9a55-11eb-83f7-ed4403d71297.png)
   
   **Which version of Dolphin Scheduler:**
    -[dev]
   
   **Additional context**
   
   
   **Requirement or improvement**
   - The DataSourceServiceImpl buildParameter() method adds a type determination, and does not set the type attribute except for the Oracle type data source
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817168798


   Yes. Let me change this. I submitted it for the first time; Ha ha。 @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817159902


   Type and ConnectType have the same value? @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei edited a comment on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei edited a comment on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817158656


   I know that the type attribute here should be the corresponding data source type, and here the connectType value is assigned to the type attribute @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817160444


   @Jonathan-Wei Yeah, you are right, we need to distinguish the type and connectType here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817157633


   `public static final String ORACLE_DB_CONNECT_TYPE = "connectType";`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817161458


   It's OK not to display the type at all. For now, the buildParameter() method splits the null value into the connectionParams parameter during processing, causing the type to be displayed as null @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] zhuangchong closed issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
zhuangchong closed issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817158030


   @Jonathan-Wei The type is connectType, it is only used by Oracle. This has been mentioned in #5083, this make confusion, and will be solved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817161997


   @Jonathan-Wei We can remove line 491.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817251487


   Merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817158656


   I know that the type attribute here should be the corresponding data source type set, and here the connectType value is assigned to the type attribute


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817161324


   It's OK not to display the type, except that the buildParameter() method splits the null value into the connectionParams parameter during processing, causing the type to be displayed as null @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817157364


   ![image](https://user-images.githubusercontent.com/3073018/114276021-6dce4900-9a57-11eb-99c6-17842f40e217.png)
   From a code point of view, whether type should be displayed here is the corresponding data type. @dailidong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei removed a comment on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei removed a comment on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817161324


   It's OK not to display the type, except that the buildParameter() method splits the null value into the connectionParams parameter during processing, causing the type to be displayed as null @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei edited a comment on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei edited a comment on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817158656


   I know that the type attribute here should be the corresponding data source type, and here the connectType value is assigned to the type attribute


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817159316


   @Jonathan-Wei No, the type is not data source type there :）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun edited a comment on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817160444


   @Jonathan-Wei Yeah, you are right, we need to distinguish the type and connectType here, and I think the type does not need to be stored in paramMap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jonathan-Wei commented on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
Jonathan-Wei commented on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817158952


   I will fix it. please assign it to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] ruanwenjun removed a comment on issue #5250: [Bug][API] Click to view the data source parameters in the data source list, and the type attribute is null

Posted by GitBox <gi...@apache.org>.
ruanwenjun removed a comment on issue #5250:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5250#issuecomment-817159316


   @Jonathan-Wei No, the type is not data source type there :）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org