[PATCH] Tab-completion in svnshell.py

[cr...@shadnet.shad.ca]

I tried to send this a few days ago, but my outgoing mail was screwed and I 
didn't see it in the archives, so I'm trying again.  My apologies if this is 
a repeat.

Attached is a patch to add tab-completion to svnshell.py.  There is only
one issue with the patch, and that's explained in the comment in the
function svnshell._complete().  If anyone knows what's going on there, I'd
love to hear it!  cd will only complete directory names, and cat will only
complete file names.  No other commands have had completion added.  
 
I've also attached a patch that exits the shell on EOF, like python does
and makes sure a newline is printed after exiting, so that the next line of
your regular shell is on its own line, like it should be.  
 
Please cc me with any comments, as I'm not subscribed to the list.  Thanks
for reading.
-- 


Craig Howard
3B Computer Science -- University of Waterloo
craig.howard@shadnet.shad.ca

Re: [PATCH] Tab-completion in svnshell.py

[cm...@collab.net]

craig.howard@shadnet.shad.ca writes:

> Attached is a patch to add tab-completion to svnshell.py.  There is only
> one issue with the patch, and that's explained in the comment in the
> function svnshell._complete().

Actually, there is another issue with the patch -- where the heck is
the log message?!  :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Tab-completion in svnshell.py

[cm...@collab.net]

craig.howard@shadnet.shad.ca writes:

> Attached is a patch to add tab-completion to svnshell.py.  There is only
> one issue with the patch, and that's explained in the comment in the
> function svnshell._complete().  If anyone knows what's going on there, I'd
> love to hear it!  cd will only complete directory names, and cat will only
> complete file names.  No other commands have had completion added.  

I applied this patch, and saw the behavior your were talking about.
*Very strange*, indeed, and unfortunately I have no idea how to stop
it from happening.  But regardless, this patch needs a log message,
and need all of its lines to fit into 80 columns.  Also (and this is
just a personal nit), if there is a way you can *not* use lambda, I
(and other like me who prefer readable code) would greatly appreciate
it.

> I've also attached a patch that exits the shell on EOF, like python does
> and makes sure a newline is printed after exiting, so that the next line of
> your regular shell is on its own line, like it should be.  

I manufactured a log message for this patch, and committed it in
revision 6576.  Thanks for it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Tab-completion in svnshell.py

[Sander Roobol <ph...@wanadoo.nl>]

On Thu, Jul 24, 2003 at 09:58:42PM -0700, craig.howard@shadnet.shad.ca wrote:
> I tried to send this a few days ago, but my outgoing mail was screwed and I 
> didn't see it in the archives, so I'm trying again.  My apologies if this is 
> a repeat.
> 
> Attached is a patch to add tab-completion to svnshell.py.  There is only
> one issue with the patch, and that's explained in the comment in the
> function svnshell._complete().  If anyone knows what's going on there, I'd
> love to hear it!  cd will only complete directory names, and cat will only
> complete file names.  No other commands have had completion added.  

Filed as issue #1459.
You don't seem to have a tigris.org account, so I wasn't able to add you
to the CC list of the issue. You can do that yourself once you have an
account.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org