You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:58:09 UTC

[GitHub] [inlong] woofyzhao commented on a diff in pull request #6020: [INLONG-6018][Manager] Utilize hive data node when creating group resources

woofyzhao commented on code in PR #6020:
URL: https://github.com/apache/inlong/pull/6020#discussion_r981031525


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/hive/HiveResourceOperator.java:
##########
@@ -78,6 +84,28 @@ public void createSinkResource(SinkInfo sinkInfo) {
         this.createTable(sinkInfo);
     }
 
+    private HiveSinkDTO getHiveInfo(SinkInfo sinkInfo) {
+        HiveSinkDTO hiveInfo = new HiveSinkDTO();
+        String dataNodeName = sinkInfo.getDataNodeName();
+
+        // firstly use data node info if exists

Review Comment:
   makes sense!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org