You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/02/14 15:53:14 UTC

[I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

keith-turner opened a new issue, #4262:
URL: https://github.com/apache/accumulo/issues/4262

   The MeterRegistryFactory does not have any mechanism for passing configuration. Since its likely metrics will need configuration (like a server to send metrics to) this leads to placing the configuration for the MeterRegistryFactory class and any options needed by the class in different places.  For example the MeterRegistryFactory class would be configured in accumulo.properties files and if it needs the hostname of a server this might be set as java system prop in accumulo-env.sh.
   
   This plugin could be modified to follow the pattern of many other SPI plugins for passing configuration to the plugin. Since a new type is being introduced in #4244, that presents a good opportunity to make this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #4262:
URL: https://github.com/apache/accumulo/issues/4262#issuecomment-1944223752

   I am currently working this as part of #4244 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #4262:
URL: https://github.com/apache/accumulo/issues/4262#issuecomment-2088855397

   Completed with #4459 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4262:
URL: https://github.com/apache/accumulo/issues/4262#issuecomment-1944115725

   Marked this for version 2.1.3 on the assumption that #4244 will be in 2.1.3.  If that turns out to not be the case then the version on this could change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #4262:
URL: https://github.com/apache/accumulo/issues/4262#issuecomment-2088850317

   @EdColeman  - was this implemented in #4459 as part of the new MeterRegistryFactory SPI class? If so, can this be closed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman closed issue #4262: MeterRegistryFactory lacks mechanism for configuration.
URL: https://github.com/apache/accumulo/issues/4262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org