You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Worms (Created) (JIRA)" <ji...@apache.org> on 2011/11/19 12:40:51 UTC
[jira] [Created] (THRIFT-1431) Rename 'sys' module to 'util'
Rename 'sys' module to 'util'
-----------------------------
Key: THRIFT-1431
URL: https://issues.apache.org/jira/browse/THRIFT-1431
Project: Thrift
Issue Type: Improvement
Components: Node.js - Library
Affects Versions: 0.7
Environment: NodeJs greater than 0.3.0
Reporter: David Worms
Fix For: 0.8
Attachments: nodejs_fix_sys.diff
Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "David Worms (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156291#comment-13156291 ]
David Worms commented on THRIFT-1431:
-------------------------------------
Just to i know how to do it, as far as i remember, I issued `svn diff > file.diff` from the Thrift root directory, is it not correct? I missed github: ) I might take a look at the test case but not before a few weeks. Thanks for applying the patch. Also, I dont think you should wait to publish those change to NPM.
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154187#comment-13154187 ]
Jake Farrell commented on THRIFT-1431:
--------------------------------------
Roger, can you take a look at this
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "David Worms (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Worms updated THRIFT-1431:
--------------------------------
Attachment: nodejs_fix_sys.diff
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "Jake Farrell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reassigned THRIFT-1431:
------------------------------------
Assignee: Roger Meier
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156438#comment-13156438 ]
Jake Farrell commented on THRIFT-1431:
--------------------------------------
David, we will push this change to NPM with the 0.8 release when it is out, we do not update the clients per patch change
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156302#comment-13156302 ]
Hudson commented on THRIFT-1431:
--------------------------------
Integrated in Thrift #341 (See [https://builds.apache.org/job/Thrift/341/])
THRIFT-1431 Rename 'sys' module to 'util'
Patch: David Worms
roger : http://svn.apache.org/viewvc/?view=rev&rev=1205576
Files :
* /thrift/trunk/.gitignore
* /thrift/trunk/lib/nodejs/lib/thrift/binary_parser.js
* /thrift/trunk/lib/nodejs/lib/thrift/connection.js
* /thrift/trunk/lib/nodejs/lib/thrift/protocol.js
* /thrift/trunk/lib/nodejs/lib/thrift/server.js
* /thrift/trunk/lib/nodejs/lib/thrift/thrift.js
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1431) Rename 'sys' module to 'util'
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1431.
---------------------------------
Resolution: Fixed
committed.
Could you please create the patch from thrift source root directory?
This makes it much easier to handle.
If you have some spare time... we need a test suite for node.js THRIFT-1134 ;-)
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (THRIFT-1431) Rename 'sys' module to
'util'
Posted by "David Worms (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156291#comment-13156291 ]
David Worms edited comment on THRIFT-1431 at 11/23/11 9:21 PM:
---------------------------------------------------------------
Just so I know how to do it, as far as i remember, I issued `svn diff > file.diff` from the Thrift root directory, is it not correct? I missed github: ) I might take a look at the test case but not before a few weeks. Thanks for applying the patch. Also, I dont think you should wait to publish those changes to NPM.
was (Author: d.worms):
Just to i know how to do it, as far as i remember, I issued `svn diff > file.diff` from the Thrift root directory, is it not correct? I missed github: ) I might take a look at the test case but not before a few weeks. Thanks for applying the patch. Also, I dont think you should wait to publish those change to NPM.
> Rename 'sys' module to 'util'
> -----------------------------
>
> Key: THRIFT-1431
> URL: https://issues.apache.org/jira/browse/THRIFT-1431
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Environment: NodeJs greater than 0.3.0
> Reporter: David Worms
> Assignee: Roger Meier
> Labels: nodejs
> Fix For: 0.8
>
> Attachments: nodejs_fix_sys.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira