You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Roman Khachatryan (Jira)" <ji...@apache.org> on 2020/12/14 10:09:00 UTC
[jira] [Closed] (FLINK-16597) Handle exception thrown from close
method in OutputFormat
[ https://issues.apache.org/jira/browse/FLINK-16597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Khachatryan closed FLINK-16597.
-------------------------------------
Fix Version/s: (was: 1.13.0)
Release Note:
Closing as DataSet API is planned for removal.
Please feel free to re-open if you think this is still important.
Resolution: Won't Fix
> Handle exception thrown from close method in OutputFormat
> ---------------------------------------------------------
>
> Key: FLINK-16597
> URL: https://issues.apache.org/jira/browse/FLINK-16597
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Task
> Affects Versions: 1.10.0, 1.11.0, 1.12.0
> Reporter: Jiayi Liao
> Assignee: Jiayi Liao
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If {{DataSinkTask}} fails or throws an exception, the {{OutputFormat}} will call {{tryCleanupOnError}} before {{close}}. But the calling order is reverse when {{DataSinkTask}} is cancelled, which doesn't make much sense that we can still clean the output format after it's closed.
> I'm not very sure if this is a bug. But this does mislead our developers when implementing our customized {{OutputFormat}}. cc [~sewen]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)