[GitHub] [pulsar] Jason918 edited a comment on pull request #14400: [PIP-74] Dependency of consumer client memory limit: support dynamic limit of consumer receiver queue

[GitBox <gi...@apache.org>]

Jason918 edited a comment on pull request #14400:
URL: https://github.com/apache/pulsar/pull/14400#issuecomment-1050817392


   > I think we need to handle the `ZeroQueueConsumerImpl` better since that case is not eligible for dynamic queue resizing, at least based on the current class design.
   
   Good catch.
   
   > I think that our API should be consistent when possible, and since `receiverQueueSize` has been on the builder since 2018, I'd prefer to update the new setter method to `setReceiverQueueSize`
   
   Good point. Previously, I use `maxReceiverQueueSize` because `receiverQueueSize` can be regarded as the current size of `incomingMessages`, actually I think `receiverQueueCapacity` maybe a proper name than `receiverQueueSize`. So let's leave it be and not change the concept at this moment.
   
   Yes, it's 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org