You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by anewstar <gi...@git.apache.org> on 2014/02/07 11:22:21 UTC
vysper pull request: change the UTF-8 encode error
GitHub user anewstar opened a pull request:
https://github.com/apache/vysper/pull/1
change the UTF-8 encode error
change the UTF-8 encode error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anewstar/vysper trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/vysper/pull/1.patch
----
commit ff3eafb612b3a267210c31290a91d5c8feebf85f
Author: wupeng <an...@163.com>
Date: 2014-02-07T10:21:09Z
change the UTF-8 encode error
----
Re: vysper pull request: change the UTF-8 encode error
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 2/10/14 1:30 PM, Bernd Fondermann a écrit :
> Hi everyone,
>
> what is our policy regarding github PRs? do we even have one? :-)
Good question...
IMHO, we are quite safe to inject the proposed patch in the code base. I
remember that once upon a time, when you attached a patch in JIRA, you
had to check a box syaing that you give back the source to The ASF, but
it's not anymore the case.
I suggest we apply the patch, and double check with legal@ that it's
safe (just in order to avoid waiting for weeks before getting an answer
from legal@...)
wdyt ?
>
> Bernd
>
> On 07.02.14 11:22, anewstar wrote:
>> GitHub user anewstar opened a pull request:
>>
>> https://github.com/apache/vysper/pull/1
>>
>> change the UTF-8 encode error
>>
>> change the UTF-8 encode error
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/anewstar/vysper trunk
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/vysper/pull/1.patch
>>
>> ----
>> commit ff3eafb612b3a267210c31290a91d5c8feebf85f
>> Author: wupeng <an...@163.com>
>> Date: 2014-02-07T10:21:09Z
>>
>> change the UTF-8 encode error
>>
>> ----
>>
>>
>
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: vysper pull request: change the UTF-8 encode error
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Hi everyone,
what is our policy regarding github PRs? do we even have one? :-)
Bernd
On 07.02.14 11:22, anewstar wrote:
> GitHub user anewstar opened a pull request:
>
> https://github.com/apache/vysper/pull/1
>
> change the UTF-8 encode error
>
> change the UTF-8 encode error
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/anewstar/vysper trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/vysper/pull/1.patch
>
> ----
> commit ff3eafb612b3a267210c31290a91d5c8feebf85f
> Author: wupeng <an...@163.com>
> Date: 2014-02-07T10:21:09Z
>
> change the UTF-8 encode error
>
> ----
>
>