You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/21 01:44:50 UTC

Review Request 24916: Allow multiple colons for docker image

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
-------

Allow multiple colons for docker image


Diffs
-----

  src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 

Diff: https://reviews.apache.org/r/24916/diff/


Testing
-------

make check.
Also tested with a local registry server and running multiple colons in the image name.


Thanks,

Timothy Chen

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/#review51193
-----------------------------------------------------------

Ship it!



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24916/#comment89225>

    Move the comments above "strings::split". Also, we usually do not use const ref for temp variables.
    
    // comments here
    // comments here
    vector<strings> parts = strings::split(...);
    if (strings::contains(parts.back(), ":")) {
      ...
    } else {
      ...
    }


- Jie Yu


On Aug. 21, 2014, 12:41 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24916/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 12:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-1724
>     https://issues.apache.org/jira/browse/MESOS-1724
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24916
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 
> 
> Diff: https://reviews.apache.org/r/24916/diff/
> 
> 
> Testing
> -------
> 
> make check.
> Also tested with a local registry server and running multiple colons in the image name.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/#review51246
-----------------------------------------------------------


Bad patch!

Reviews applied: [24916]

Failed command: git apply --index 24916.patch

Error:
 error: patch failed: src/slave/containerizer/docker.cpp:441
error: src/slave/containerizer/docker.cpp: patch does not apply

- Mesos ReviewBot


On Aug. 21, 2014, 7:06 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24916/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 7:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-1724
>     https://issues.apache.org/jira/browse/MESOS-1724
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24916
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 
> 
> Diff: https://reviews.apache.org/r/24916/diff/
> 
> 
> Testing
> -------
> 
> make check.
> Also tested with a local registry server and running multiple colons in the image name.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/
-----------------------------------------------------------

(Updated Aug. 21, 2014, 7:06 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-1724
    https://issues.apache.org/jira/browse/MESOS-1724


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/24916


Diffs
-----

  src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 

Diff: https://reviews.apache.org/r/24916/diff/


Testing
-------

make check.
Also tested with a local registry server and running multiple colons in the image name.


Thanks,

Timothy Chen

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/
-----------------------------------------------------------

(Updated Aug. 21, 2014, 7:06 p.m.)


Review request for drill, Benjamin Hindman and Jie Yu.


Bugs: MESOS-1724
    https://issues.apache.org/jira/browse/MESOS-1724


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/24916


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 

Diff: https://reviews.apache.org/r/24916/diff/


Testing
-------

make check.
Also tested with a local registry server and running multiple colons in the image name.


Thanks,

Timothy Chen

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/
-----------------------------------------------------------

(Updated Aug. 21, 2014, 12:41 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-1724
    https://issues.apache.org/jira/browse/MESOS-1724


Repository: mesos-git


Description (updated)
-------

Review: https://reviews.apache.org/r/24916


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 

Diff: https://reviews.apache.org/r/24916/diff/


Testing
-------

make check.
Also tested with a local registry server and running multiple colons in the image name.


Thanks,

Timothy Chen

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/#review51152
-----------------------------------------------------------



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24916/#comment89186>

    If the image is:
    ```
    my.registry.com:12345/myimage
    ```
    
    my understanding is that we should append `:latest` to the end, right?


- Jie Yu


On Aug. 20, 2014, 11:45 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24916/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 11:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-1724
>     https://issues.apache.org/jira/browse/MESOS-1724
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Allow multiple colons for docker image
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 
> 
> Diff: https://reviews.apache.org/r/24916/diff/
> 
> 
> Testing
> -------
> 
> make check.
> Also tested with a local registry server and running multiple colons in the image name.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24916: Allow multiple colons for docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24916/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 11:45 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-1724
    https://issues.apache.org/jira/browse/MESOS-1724


Repository: mesos-git


Description
-------

Allow multiple colons for docker image


Diffs
-----

  src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa 

Diff: https://reviews.apache.org/r/24916/diff/


Testing
-------

make check.
Also tested with a local registry server and running multiple colons in the image name.


Thanks,

Timothy Chen