You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Kevin Brown (JIRA)" <ji...@apache.org> on 2008/03/23 09:13:24 UTC
[jira] Created: (SHINDIG-147) Migrate all servlets to
org.apache.shindig.http
Migrate all servlets to org.apache.shindig.http
-----------------------------------------------
Key: SHINDIG-147
URL: https://issues.apache.org/jira/browse/SHINDIG-147
Project: Shindig
Issue Type: Bug
Components: Gadgets Server - Java, OpenSocial - Server
Reporter: Kevin Brown
Currently we have servlets in gadgets/http and social/.
This doesn't really make any sense -- all the servlets, regardless of what data they manipulate, should go in one place. I suggest org.apache.shindig.http or possibly org.apache.shindig.servlets.
We can then ensure that we have consistency in the shared details between gadget rendering and social data, such as OAuth.
I like the conceptual separation of social data vs. gadgets for everything else, but I think the servlets should ultimately be in one place for deployment and clarity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Martin Webb <ma...@gmail.com>.
Created a patch: https://issues.apache.org/jira/browse/SHINDIG-156
--
Internet Related Technologies - http://www.irt.org
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Kevin Brown <et...@google.com>.
On Wed, Mar 26, 2008 at 7:37 PM, Martin Webb <ma...@gmail.com>
wrote:
> On Tue, Mar 25, 2008 at 10:18 AM, Kevin Brown <et...@google.com> wrote:
>
> > The default build already does produce a jar. You'll still get some
> > non-reusable pieces, but you can safely ignore those. When we start
> doing
> > production releases these will be included in the apache maven
> repository
> > as
> > well.
> >
>
> I'm wary of making a hard-wired dependency to the build's JAR that might
> not
> be present on everyone's setup.
>
> I've tried a local: mvn install - which generates:
>
> [INFO] Building jar: d:\workspace\shindig\java\gadgets\target\gadgets-
> sources.jar
> [INFO] [jar:jar {execution: default}]
> [INFO] Building jar: d:\workspace\shindig\java\gadgets\target\gadgets.jar
> [INFO] [install:install]
> [INFO] Installing d:\workspace\shindig\java\gadgets\target\gadgets.jar to
> d:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
> 1-SNAPSHOT.war
> [INFO] Installing d:\workspace\shindig\java\gadgets\target\gadgets-
> sources.jar to
> d:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
> 1-SNAPSHOT-sources.jar
>
> And then added a dependency to my gadget container:
>
> <dependency>
> <groupId>org.apache.shindig</groupId>
> <artifactId>gadgets</artifactId>
> <version>1-SNAPSHOT</version>
> </dependency>
>
> Which results in the error:
> Project 'container' is missing required library:
> 'D:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
> 1-SNAPSHOT.jar'
>
> I can see that the local mvn install created: gadgets-1-SNAPSHOT.war and
> gadgets-1-SNAPSHOT-sources.jar, but not a gadgets-1-SNAPSHOT.jar
>
> Is it possible to amend the shindig pom.xml in some way to generate and
> locally publish the jar now when doing an install?
I assume it is, but I'm not a maven expert.
>
>
> --
> Internet Related Technologies - http://www.irt.org
>
--
~Kevin
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Martin Webb <ma...@gmail.com>.
On Tue, Mar 25, 2008 at 10:18 AM, Kevin Brown <et...@google.com> wrote:
> The default build already does produce a jar. You'll still get some
> non-reusable pieces, but you can safely ignore those. When we start doing
> production releases these will be included in the apache maven repository
> as
> well.
>
I'm wary of making a hard-wired dependency to the build's JAR that might not
be present on everyone's setup.
I've tried a local: mvn install - which generates:
[INFO] Building jar: d:\workspace\shindig\java\gadgets\target\gadgets-
sources.jar
[INFO] [jar:jar {execution: default}]
[INFO] Building jar: d:\workspace\shindig\java\gadgets\target\gadgets.jar
[INFO] [install:install]
[INFO] Installing d:\workspace\shindig\java\gadgets\target\gadgets.jar to
d:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
1-SNAPSHOT.war
[INFO] Installing d:\workspace\shindig\java\gadgets\target\gadgets-
sources.jar to
d:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
1-SNAPSHOT-sources.jar
And then added a dependency to my gadget container:
<dependency>
<groupId>org.apache.shindig</groupId>
<artifactId>gadgets</artifactId>
<version>1-SNAPSHOT</version>
</dependency>
Which results in the error:
Project 'container' is missing required library:
'D:\.m2\repository\org\apache\shindig\gadgets\1-SNAPSHOT\gadgets-
1-SNAPSHOT.jar'
I can see that the local mvn install created: gadgets-1-SNAPSHOT.war and
gadgets-1-SNAPSHOT-sources.jar, but not a gadgets-1-SNAPSHOT.jar
Is it possible to amend the shindig pom.xml in some way to generate and
locally publish the jar now when doing an install?
--
Internet Related Technologies - http://www.irt.org
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Kevin Brown <et...@google.com>.
On Tue, Mar 25, 2008 at 2:46 AM, Martin Webb <ma...@gmail.com>
wrote:
> Kevin,
>
> True. I misspoke. Could we package up all the Java code into a JAR (or all
> the code that is reuseable outside of just the gadget server)?
The default build already does produce a jar. You'll still get some
non-reusable pieces, but you can safely ignore those. When we start doing
production releases these will be included in the apache maven repository as
well.
As far as your specific goal, take a look at my response in the other
thread.
--
~Kevin
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Martin Webb <ma...@gmail.com>.
On Tue, Mar 25, 2008 at 8:14 AM, Kevin Brown <et...@google.com> wrote:
> On Tue, Mar 25, 2008 at 12:54 AM, Martin Webb <ma...@gmail.com>
> wrote:
>
> > >
> > > Currently we have servlets in gadgets/http and social/.
> > >
> > > This doesn't really make any sense -- all the servlets, regardless of
> > what
> > > data they manipulate, should go in one place. I suggest
> > > org.apache.shindig.http or possibly org.apache.shindig.servlets.
> > >
> > > We can then ensure that we have consistency in the shared details
> > between
> > > gadget rendering and social data, such as OAuth.
> > >
> >
> > Will it be possible to also extract the servlets out into their own
> child
> > maven project - so that they can be wrapped as a jar and used in both
> the
> > gadget server and in separate gadget container web apps as a maven
> > dependency?
>
>
> I don't really see much point -- the servlets are useless without the code
> they depend on. I'd expect the non-servlet stuff to see some re-use (which
> is the reason why the servlets are separate to begin with), but I don't
> see
> what good the servlets would do without the core classes.
>
> >
> >
> > Martin
> >
>
>
>
> --
> ~Kevin
>
Kevin,
True. I misspoke. Could we package up all the Java code into a JAR (or all
the code that is reuseable outside of just the gadget server)? As per
another thread:
I'm running a gadget container on a different domain/port than the gadget
server - and thus cannot directly call the metadata servlet from the browser
using JSON with POST. I'd rather not clone the servlet code and copy into
my gadget container... I'd also rather not add a proxy servlet to my gadget
container to make the x-domain calls (this might be a sensible approach for
some, but in complex environments this might not be possible)
Regards
Martin
--
Internet Related Technologies - http://www.irt.org
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Kevin Brown <et...@google.com>.
On Tue, Mar 25, 2008 at 12:54 AM, Martin Webb <ma...@gmail.com>
wrote:
> >
> > Currently we have servlets in gadgets/http and social/.
> >
> > This doesn't really make any sense -- all the servlets, regardless of
> what
> > data they manipulate, should go in one place. I suggest
> > org.apache.shindig.http or possibly org.apache.shindig.servlets.
> >
> > We can then ensure that we have consistency in the shared details
> between
> > gadget rendering and social data, such as OAuth.
> >
>
> Will it be possible to also extract the servlets out into their own child
> maven project - so that they can be wrapped as a jar and used in both the
> gadget server and in separate gadget container web apps as a maven
> dependency?
I don't really see much point -- the servlets are useless without the code
they depend on. I'd expect the non-servlet stuff to see some re-use (which
is the reason why the servlets are separate to begin with), but I don't see
what good the servlets would do without the core classes.
>
>
> Martin
>
--
~Kevin
Re: [jira] Created: (SHINDIG-147) Migrate all servlets to org.apache.shindig.http
Posted by Martin Webb <ma...@gmail.com>.
>
> Currently we have servlets in gadgets/http and social/.
>
> This doesn't really make any sense -- all the servlets, regardless of what
> data they manipulate, should go in one place. I suggest
> org.apache.shindig.http or possibly org.apache.shindig.servlets.
>
> We can then ensure that we have consistency in the shared details between
> gadget rendering and social data, such as OAuth.
>
Will it be possible to also extract the servlets out into their own child
maven project - so that they can be wrapped as a jar and used in both the
gadget server and in separate gadget container web apps as a maven
dependency?
Martin
[jira] Closed: (SHINDIG-147) Migrate all servlets to
org.apache.shindig.http
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-147.
-------------------------------
Resolution: Won't Fix
Yep.
> Migrate all servlets to org.apache.shindig.http
> -----------------------------------------------
>
> Key: SHINDIG-147
> URL: https://issues.apache.org/jira/browse/SHINDIG-147
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java), Gadget Rendering Server (Java)
> Reporter: Kevin Brown
>
> Currently we have servlets in gadgets/http and social/.
> This doesn't really make any sense -- all the servlets, regardless of what data they manipulate, should go in one place. I suggest org.apache.shindig.http or possibly org.apache.shindig.servlets.
> We can then ensure that we have consistency in the shared details between gadget rendering and social data, such as OAuth.
> I like the conceptual separation of social data vs. gadgets for everything else, but I think the servlets should ultimately be in one place for deployment and clarity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-147) Migrate all servlets to
org.apache.shindig.http
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590482#action_12590482 ]
Cassie Doll commented on SHINDIG-147:
-------------------------------------
I don't think this bug really makes sense anymore as we have two completely separate servers. Should we close this?
> Migrate all servlets to org.apache.shindig.http
> -----------------------------------------------
>
> Key: SHINDIG-147
> URL: https://issues.apache.org/jira/browse/SHINDIG-147
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java), Gadget Rendering Server (Java)
> Reporter: Kevin Brown
>
> Currently we have servlets in gadgets/http and social/.
> This doesn't really make any sense -- all the servlets, regardless of what data they manipulate, should go in one place. I suggest org.apache.shindig.http or possibly org.apache.shindig.servlets.
> We can then ensure that we have consistency in the shared details between gadget rendering and social data, such as OAuth.
> I like the conceptual separation of social data vs. gadgets for everything else, but I think the servlets should ultimately be in one place for deployment and clarity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.