[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #5883: fix: type coercion for expr/subquery in InSubquery

["liukun4515 (via GitHub)" <gi...@apache.org>]

liukun4515 commented on code in PR #5883:
URL: https://github.com/apache/arrow-datafusion/pull/5883#discussion_r1160386833


##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -326,7 +317,12 @@ impl ExprSchemable for Expr {
     }
 }
 
-fn cast_subquery(subquery: Subquery, cast_to_type: &DataType) -> Result<Subquery> {
+/// cast subquery in InSubquery/ScalarSubquery to a given type.

Review Comment:
   I find this method is used in `scalar subquer`, but the comment is for Insubquery/scalarquery.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org