You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/02/02 06:17:37 UTC

[GitHub] wangqiaoshi edited a comment on issue #119: [LIVY-527] added autocompletion api and implementation for ipython

wangqiaoshi edited a comment on issue #119: [LIVY-527] added autocompletion api and implementation for ipython
URL: https://github.com/apache/incubator-livy/pull/119#issuecomment-459933954
 
 
   > Some style issues, otherwise looks ok.
   > 
   > Can a test be written for this (e.g. in `InteractiveIT`)? Not sure how easy it is to hit the completion API from tests.
   
   I have a doubt, ` InteractiveIT `  isn't find  ` Kind ` . Because module ` livy - integration - the test ` not introduced ` livy - core - the parent `, but ` Kind ` in module ` livy - core - the parent `. I can't run ` InteractiveIT `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services