You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/02/02 06:43:59 UTC

[GitHub] marcoabreu commented on a change in pull request #9672: CMake CUDA fixes + NCCL

marcoabreu commented on a change in pull request #9672: CMake CUDA fixes + NCCL
URL: https://github.com/apache/incubator-mxnet/pull/9672#discussion_r165568608
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -168,12 +167,43 @@ endif()
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src)
 
-if(FIRST_CUDA)
+if(USE_CUDA)
+  find_package(CUDA REQUIRED)
+  add_definitions(-DMSHADOW_USE_CUDA=1)
+  if(FIRST_CUDA AND (NOT USE_OLDCMAKECUDA))
+    if(CUDA_TOOLSET STREQUAL "")
+      set(CUDA_TOOLSET "${CUDA_VERSION_STRING}")
 
 Review comment:
   What happens if I want to compile using Cuda 8, although my system supports cuda 9 or does not have a GPU? Would it still pick Cuda 8 according to the configuration?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services