You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2014/04/09 08:24:29 UTC

Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
-----------------------------------------------------------

(Updated April 9, 2014, 6:24 a.m.)


Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.


Changes
-------

Added timestamp validation


Bugs: CLOUDSTACK-6253
    https://issues.apache.org/jira/browse/CLOUDSTACK-6253


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router


Diffs (updated)
-----

  core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
  plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
  systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
  test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
  test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 

Diff: https://reviews.apache.org/r/19578/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39881
-----------------------------------------------------------


Commit ecc71518a9a9fe1d7078a90dcbb4bbcc9bc2ca61 in cloudstack's branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ecc7151 ]

CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router


- ASF Subversion and Git Services


On April 9, 2014, 12:28 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19578/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 12:28 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-6253
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6253
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
> In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
>   core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
>   plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
>   systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
>   test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
>   test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 
> 
> Diff: https://reviews.apache.org/r/19578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39880
-----------------------------------------------------------


Commit 68c80e28c09a9459e3cf1c79f45718fb3b3678c7 in cloudstack's branch refs/heads/4.4 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=68c80e2 ]

CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router


- ASF Subversion and Git Services


On April 9, 2014, 12:28 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19578/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 12:28 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-6253
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6253
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
> In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
>   core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
>   plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
>   systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
>   test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
>   test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 
> 
> Diff: https://reviews.apache.org/r/19578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39882
-----------------------------------------------------------

Ship it!


master ecc71518a9a9fe1d7078a90dcbb4bbcc9bc2ca61
4.4 68c80e28c09a9459e3cf1c79f45718fb3b3678c7

- Murali Reddy


On April 9, 2014, 12:28 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19578/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 12:28 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-6253
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6253
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
> In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
>   core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
>   engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
>   plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
>   systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
>   test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
>   test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 
> 
> Diff: https://reviews.apache.org/r/19578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
-----------------------------------------------------------

(Updated April 9, 2014, 12:28 p.m.)


Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.


Bugs: CLOUDSTACK-6253
    https://issues.apache.org/jira/browse/CLOUDSTACK-6253


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router


Diffs
-----

  core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
  plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
  systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
  test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
  test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 

Diff: https://reviews.apache.org/r/19578/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 19578: CLOUDSTACK-6253: Optimizing VR alerts getting algorithm

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
-----------------------------------------------------------

(Updated April 9, 2014, 12:28 p.m.)


Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.


Bugs: CLOUDSTACK-6253
    https://issues.apache.org/jira/browse/CLOUDSTACK-6253


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6253: Optimizing VR alerts getting algorithm 
In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router


Diffs (updated)
-----

  core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java 06a7a7a 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java df4ed2c 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java e3f75fa 
  engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 6b62f56 
  plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java 23979c0 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java e3597ac 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0899f42 
  systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh e5e8abe 
  test/integration/component/test_VirtualRouter_alerts.py PRE-CREATION 
  test/integration/smoke/test_VirtualRouter_alerts.py caa9fc5 

Diff: https://reviews.apache.org/r/19578/diff/


Testing
-------


Thanks,

Harikrishna Patnala