You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/01/28 03:30:20 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new issue, #1323: Unify configuration launch method
acelyc111 opened a new issue, #1323:
URL: https://github.com/apache/incubator-pegasus/issues/1323
There are two types of configuration launch methods in the code.
One is using gflag like macros, e.g.
```
#define DSN_DEFINE_uint64(section, name, val, desc)
```
The other is using functions, e.g.
```
uint64_t dsn_config_get_value_uint64(const char *section,
const char *key,
uint64_t default_value,
const char *dsptr);
```
It's strange to keep the two methods in long term, We're planning to refactor them and only leave `DSN_DEFINE_*` ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1323: Unify configuration launch method
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on issue #1323:
URL: https://github.com/apache/incubator-pegasus/issues/1323#issuecomment-1450354052
There are some configs are launched by macros `CONFIG_BEGIN`, `CONFIG_FLD*` and `CONFIG_END`, we can refactor them in another issuse, this one closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed issue #1323: Unify configuration launch method
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 closed issue #1323: Unify configuration launch method
URL: https://github.com/apache/incubator-pegasus/issues/1323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org