You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/03/30 22:22:32 UTC
Review Request 45503: GEODE-962:
RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45503/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.
Repository: geode
Description
-------
GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure (on specifically Docker)
- Updated trusted.keystore and untrusted.keystore to have certificates that will only expire in 2026.
- Changed the way that the HTTP client creates a SSLContext.
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 1656eda898767b4272b07944ccbda975b1a97ab0
geode-core/src/test/resources/ssl/trusted.keystore ac40e04b8599850e9d21833cd9df61fb3db3c1fa
geode-core/src/test/resources/ssl/untrusted.keystore aa73eeb4c6a586cee40092194898c9e75a052d2b
Diff: https://reviews.apache.org/r/45503/diff/
Testing
-------
distributedTests passing on local and on docker.
Thanks,
Udo Kohlmeyer
Re: Review Request 45503: GEODE-962:
RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45503/#review126665
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On March 30, 2016, 8:22 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45503/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 8:22 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure (on specifically Docker)
> - Updated trusted.keystore and untrusted.keystore to have certificates that will only expire in 2026.
> - Changed the way that the HTTP client creates a SSLContext.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 1656eda898767b4272b07944ccbda975b1a97ab0
> geode-core/src/test/resources/ssl/trusted.keystore ac40e04b8599850e9d21833cd9df61fb3db3c1fa
> geode-core/src/test/resources/ssl/untrusted.keystore aa73eeb4c6a586cee40092194898c9e75a052d2b
>
> Diff: https://reviews.apache.org/r/45503/diff/
>
>
> Testing
> -------
>
> distributedTests passing on local and on docker.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45503: GEODE-962:
RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On March 30, 2016, 10:29 p.m., Bruce Schuchardt wrote:
> > Is there any documentation that shows how to create the HTTP client? If so does it need to be modified?
I don't think that we have any documentation on creating an HTTP client. We specify we expose via REST and it is up to the implementing customer to know how to create an HTTPs connection. This problem is limited to our implementation of the test client.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45503/#review126209
-----------------------------------------------------------
On March 30, 2016, 8:22 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45503/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 8:22 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure (on specifically Docker)
> - Updated trusted.keystore and untrusted.keystore to have certificates that will only expire in 2026.
> - Changed the way that the HTTP client creates a SSLContext.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 1656eda898767b4272b07944ccbda975b1a97ab0
> geode-core/src/test/resources/ssl/trusted.keystore ac40e04b8599850e9d21833cd9df61fb3db3c1fa
> geode-core/src/test/resources/ssl/untrusted.keystore aa73eeb4c6a586cee40092194898c9e75a052d2b
>
> Diff: https://reviews.apache.org/r/45503/diff/
>
>
> Testing
> -------
>
> distributedTests passing on local and on docker.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45503: GEODE-962:
RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45503/#review126209
-----------------------------------------------------------
Ship it!
Is there any documentation that shows how to create the HTTP client? If so does it need to be modified?
- Bruce Schuchardt
On March 30, 2016, 8:22 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45503/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 8:22 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure (on specifically Docker)
> - Updated trusted.keystore and untrusted.keystore to have certificates that will only expire in 2026.
> - Changed the way that the HTTP client creates a SSLContext.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 1656eda898767b4272b07944ccbda975b1a97ab0
> geode-core/src/test/resources/ssl/trusted.keystore ac40e04b8599850e9d21833cd9df61fb3db3c1fa
> geode-core/src/test/resources/ssl/untrusted.keystore aa73eeb4c6a586cee40092194898c9e75a052d2b
>
> Diff: https://reviews.apache.org/r/45503/diff/
>
>
> Testing
> -------
>
> distributedTests passing on local and on docker.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>