You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/20 04:05:09 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
kezhenxu94 opened a new issue #7757:
URL: https://github.com/apache/skywalking/issues/7757
### Discussed in https://github.com/apache/skywalking/discussions/7756
<div type='discussions-op-text'>
<sup>Originally posted by **tisonkun** September 20, 2021</sup>
https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/
It seems the checker only allows full-text license header.
cc @kezhenxu94 @fgksgf </div>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tisonkun commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1030997553
@kezhenxu94 yes. What I propose here is that we don't have to implement something new to meet the original requirement. But add a test preventing regression, and when incoming users ask for verifying SPDX license identifier, tell them to do it in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1032145706
> @kezhenxu94 yes. What I propose here is that we don't have to implement something new to meet the original requirement. But add a test preventing regression, and when incoming users ask for verifying SPDX license identifier, tell them to do it in this way.
That sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1032161733
> So, we should close this?
If @tisonkun is willing to add the test for regression we can keep on track in this issue otherwise let's close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tisonkun commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1030836357
If so, we can add a test and close this issue as provided out-of-the-box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tisonkun commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1030836590
Also the link above is broken. It's now https://spdx.github.io/spdx-spec/using-SPDX-short-identifiers-in-source-files/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7757:
URL: https://github.com/apache/skywalking/issues/7757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1032158956
So, we should close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tisonkun commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1032164918
Let me give it a try in this week :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tisonkun commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1030836267
@kezhenxu94 possibly we can just achieve this with:
```yml
header:
license:
spdx-id: Apache-2.0
content: |
SPDX-License-Identifier: Apache-2.0
```
thanks to SPDX license identifier is simple :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7757: Does skywalking-eyes support SPDX-short-identifiers?
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7757:
URL: https://github.com/apache/skywalking/issues/7757#issuecomment-1030973606
> @kezhenxu94 possibly we can just achieve this with:
>
>
>
> ```yml
>
> header:
>
> license:
>
> spdx-id: Apache-2.0
>
> content: |
>
> SPDX-License-Identifier: Apache-2.0
>
> ```
>
>
>
> thanks to SPDX license identifier is simple :)
In this example the spdx identifier is nothing special comparing to a plain header content though that will also satisfy your requirement. (BTW with `content` set, the `spdx-id` is simply ignored.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org