[GitHub] WillemJiang commented on issue #763: Allow installing additional dynamic configurations

[GitBox <gi...@apache.org>]

WillemJiang commented on issue #763: Allow installing additional dynamic configurations
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/763#issuecomment-396101427
 
 
   @DogRex  Thanks for the contribution, you don't need to expose so much your personal information here.  
   As we using [JIRA](http://issues.apache.org/jira/browse/SCB) to managed the issues,  please fill a JIRA first with enough information about what kind of issue that you want to fix and how you fix it. The we can associate this issue of JIRA by adding the JIRA number on the issue title. 
   
   Please check out[ this document](http://servicecomb.incubator.apache.org/cn/developers/use-jira/) if you are new to apache JIRA system.
   
   There is an CI build error in you PR, as it break some other unit test. 
   
   Results :
   Failed tests: 
     TestConfigUtil.propertiesFromFileIsDuplicatedToCse:155 
   Expected: "value"
        but: was "valueToOverride"
     TestConfigUtil.testGetOtherConfiguration:94 expected:<other_config.value1> but was:<DynamicProperty: {name=other_config.key1, current value=other_config.value1}>
   Tests run: 35, Failures: 2, Errors: 0, Skipped: 0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services