You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by TheRealHaui <gi...@git.apache.org> on 2017/06/16 19:32:24 UTC
[GitHub] commons-compress pull request #35: Compress 412
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-compress/pull/35
Compress 412
Fixed Jira issue Compress 412: https://issues.apache.org/jira/browse/COMPRESS-412
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-compress COMPRESS-412
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 2f45456527f2631ef8b4bb09aa0ad30afda02b5f
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-13T21:47:50Z
add-some-Unit-Tests Added some Unit Tests to increase code coverage.
commit 96ca8ceeddbd20ec38b9211260b4b91107b0be2d
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-16T18:12:20Z
add-some-Unit-Tests Removed @author tags in comments.
commit 5e5dc7f032ffb5b3818410e23d7881a8def46f3d
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-16T18:22:10Z
add-some-Unit-Tests Removed test testGetValueThrowsNullPointerException in class ChecksumCalculatingInputStreamTest. Test represented a bug/defect which is going to be fixed in a different branch.
commit be0f11f4dbffb5ca1f903a6f07de744687d303c3
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-16T18:38:00Z
add-some-Unit-Tests Minor variable renaming.
commit 3b46bb5dc3aeb3ca68062c10589e049c9eb8551d
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-16T18:44:40Z
add-some-Unit-Tests Added myself as contributor to pom.xml as "requested" by Stefan Bodewig.
commit a0e5dd80b9ec43c315021701f9c2334be45c6271
Author: Michael Hausegger <mi...@tugraz.at>
Date: 2017-06-16T19:30:03Z
COMPRESS-412 NullPointerException defect in ChecksumCalculatingInputStream#getValue() fixed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #35: Compress 412
Posted by TheRealHaui <gi...@git.apache.org>.
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/35
@bodewig
Explicitely created and switched to a new branch to circumvent this.
Don't know what went wrong.
However, you're welcome - was a pleasure to work with you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #35: Compress 412
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/35
Thanks, I had to cherry pick 6f37913 but I think I've got everything merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #35: Compress 412
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/35
[](https://:/builds/12009215)
Coverage increased (+0.2%) to 84.678% when pulling **a0e5dd80b9ec43c315021701f9c2334be45c6271 on TheRealHaui:COMPRESS-412** into **7254daa3f84a2b7780050da936304ea42db324ef on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #35: Compress 412
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org