[GitHub] [kafka] C0urante commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

[GitBox <gi...@apache.org>]

C0urante commented on pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#issuecomment-737550229


   @lbradstreet I think the changes to the MM2 tests may have been unnecessary or, at least, inadequate. Embedded Connect clusters automatically [mask exit procedures on startup](https://github.com/apache/kafka/blob/aeeb7b2f9a9abe8f49543a2278757722e5974cb3/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java#L128-L138) by default, which should apply to the MM2 integration tests.
   
   I believe the issue with the MM2 integration tests is that embedded Connect clusters also automatically [reset exit procedures on shutdown](https://github.com/apache/kafka/blob/aeeb7b2f9a9abe8f49543a2278757722e5974cb3/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java#L156-L157). Since the tests use two embedded Connect clusters which are shut down sequentially at the end of each test case, the second cluster to be shut down does so without using the masked exit procedures, which can result in `System::exit` being invoked.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org