[GitHub] [rocketmq-connect] duhenglucky commented on a diff in pull request #232: [ISSUE #230]Optimize plugin loading cloass loader, and support rest API to get connector plugin list

[GitBox <gi...@apache.org>]

duhenglucky commented on code in PR #232:
URL: https://github.com/apache/rocketmq-connect/pull/232#discussion_r940803687


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/rest/RestHandler.java:
##########
@@ -70,7 +74,13 @@ public RestHandler(AbstractConnectController connectController) {
         app.get("/getConfigInfo", this::getConfigInfo);
         app.get("/getAllocatedConnectors", this::getAllocatedConnectors);
         app.get("/getAllocatedTasks", this::getAllocatedTasks);
-        app.get("/plugin/reload", this::reloadPlugins);
+

Review Comment:
   An additional suggestion, now all rest APIs of connect do not have a unified return format, which brings certain difficulties to the integration of external systems. I wonder if you are willing to unify the request and response format, which can bring great benefits to developers and users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org