[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9775:
URL: https://github.com/apache/skywalking/pull/9775#discussion_r993204004


##########
docs/en/setup/backend/backend-apisix-monitoring.md:
##########
@@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to
 2. Set up [OpenTelemetry Collector ](https://opentelemetry.io/docs/collector/getting-started/#docker). For details on Prometheus Receiver in OpenTelemetry Collector, refer to [here](../../../../test/e2e-v2/cases/apisix/otel-collector/otel-collector-config.yaml).
 3. Config SkyWalking [OpenTelemetry receiver](opentelemetry-receiver.md).
 
-### MySQL Monitoring
+### APISIX Monitoring
 [APISIX prometheus plugin](https://apisix.apache.org/docs/apisix/plugins/prometheus/) provide multiple dimensions metrics for APISIX server , node , route , etc. 
-Accordingly, Skywalking observes the status, payload, and latency of the APISIX server, which is cataloged as a `LAYER: APISIX` `Service` in the OAP. Meanwhile, the server node would be recognized as `instance, and the route rule would be recognized as `endpoint`.
+Accordingly, Skywalking observes the status, payload, and latency of the APISIX server, which is cataloged as a `LAYER: APISIX` `Service` in the OAP. Meanwhile, the APISIX instance would be recognized as `LAYER: APISIX` `instance`, and the route rule , node would be recognized as `LAYER: APISIX` `endpoint`.

Review Comment:
   ```suggestion
   Accordingly, Skywalking observes the status, payload, and latency of the APISIX server, which is cataloged as a `LAYER: APISIX` `Service` in the OAP. Meanwhile, the instances would be recognized as `LAYER: APISIX` `instance`s. The route rules and nodes would be recognized as `endpoint`s with `route/` and `node/` prefixes.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org