[jira] Resolved: (THRIFT-159) Compiler doesn't add package scope to exceptions in catch blocks and assigns to unused local var when reading

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury resolved THRIFT-159.
----------------------------------

    Resolution: Fixed

Committed.

> Compiler doesn't add package scope to exceptions in catch blocks and assigns to unused local var when reading
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-159
>                 URL: https://issues.apache.org/jira/browse/THRIFT-159
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (C#)
>            Reporter: Dave Engberg
>         Attachments: t_csharp_generator.cc.patch
>
>
> I'm submitting a patch to the C# compiler that fixes two issues:
> First, when the generator emits a 'catch (YourException foo)' for an exception that is in another namespace, the compiler does not fully qualify the class name with the namespace, which prevents the code from compiling.  This patch adds the module prefix onto exception names in catch blocks.
> Second, the generated read methods invoke ReadStructBegin() and assign the result to a local variable that is never used:
> TStruct struc = iprot.ReadStructBegin();
> This makes the Mono compiler give a warning for each generated class.  This patch eliminates the dummy local variable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.