[GitHub] brodybits opened a new pull request #155: 4.2.4 patch update

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #155: 4.2.4 patch update
URL: https://github.com/apache/cordova-js/pull/155
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   Proposed changes for `4.2.x` branch (NOT for master):
   
   - Use npm@5 on AppVeyor to resolve issue with CI on Node.js 4
   - Drop support for old Cordova platforms
   - Use `github:brodybits/jasmine-node#1.15.0-rc1` in `devDependencies` to resolve `npm audit` warning (see note below)
   - CB-9366 Log error.stack as proposed by @nikhilkh in #118, with JavaScript fix by @brodybits
   - Update version & RELEASENOTES.md for release 4.2.4
   - Increment package version to 4.2.5-dev
   
   NOTE: `github:brodybits/jasmine-node#1.15.0-rc1` specifies a special version of jasmine-node that I made in my fork with changes proposed in <https://github.com/mhevery/jasmine-node/pull/429> to resolve `npm audit` issues. This special version is needed due to lack of maintenance as discussed in <https://github.com/mhevery/jasmine-node/issues/430>. I already requested owner access to the NPM module according to <https://www.npmjs.com/policies/disputes>, may have to wait a month for this.
   
   The use of brodybits/jasmine-node patch will NOT be part of master. The solution for the next major release is to migrate to jasmine, with some changes to require() imports, as proposed by @audreyso in #140.
   
   ### What testing has been done on this change?
   
   - Most of these changes were verified to pass CI in @151 and a couple other PRs that I had closed.
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org