You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/23 12:54:19 UTC
[GitHub] [incubator-kyuubi] cfmcgrady opened a new pull request, #3121: [CI] Fix GA oom issue
cfmcgrady opened a new pull request, #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928532860
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -36,7 +40,7 @@ trait WithKyuubiServer extends KyuubiFunSuite {
protected var server: KyuubiServer = _
override def beforeAll(): Unit = {
- conf.set(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
+ conf.setIfMissing(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
Review Comment:
this is why the k8s integration tests hang. cc @turboFei
<details>
<summary>logs</summary>
```
17:28:35.138 INFO org.apache.kyuubi.session.KyuubiBatchSessionImpl: There are still remaining metadata store requests for batch[8b2bce8d-69a9-4284-9cfd-ee9c140721d8]
17:28:35.268 INFO org.apache.kyuubi.server.metadata.MetadataManager: Retrying metadata requests for 8b2bce8d-69a9-4284-9cfd-ee9c140721d8
17:28:35.269 ERROR org.apache.kyuubi.server.metadata.MetadataManager: Error retrying metadata requests for 8b2bce8d-69a9-4284-9cfd-ee9c140721d8
org.apache.kyuubi.KyuubiException: Error executing
INSERT INTO metadata(
identifier,
session_type,
real_user,
user_name,
ip_address,
kyuubi_instance,
state,
resource,
class_name,
request_name,
request_conf,
request_args,
create_time,
engine_type,
cluster_manager
)
VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
:Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:372) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$insertMetadata$1(JDBCMetadataStore.scala:151) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$insertMetadata$1$adapted(JDBCMetadataStore.scala:133) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withConnection(JDBCMetadataStore.scala:445) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.insertMetadata(JDBCMetadataStore.scala:133) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.MetadataManager.insertMetadata(MetadataManager.scala:81) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.MetadataManager$$anon$1$$anon$2.run(MetadataManager.scala:225) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: java.sql.SQLIntegrityConstraintViolationException: Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:369) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 11 more
Caused by: org.apache.derby.iapi.error.StandardException: Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeColumn(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeRow(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.InsertResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.executeStmt(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:369) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 11 more
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#issuecomment-1193133763
cc @pan3793 @yaooqinn @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928535092
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -52,13 +54,23 @@ trait WithKyuubiServer extends KyuubiFunSuite {
conf.set("spark.ui.enabled", "false")
conf.setIfMissing("spark.sql.catalogImplementation", "in-memory")
+ conf.setIfMissing("kyuubi.ha.zookeeper.connection.retry.policy", "ONE_TIME")
conf.setIfMissing(ENGINE_CHECK_INTERVAL, 1000L)
conf.setIfMissing(ENGINE_IDLE_TIMEOUT, 5000L)
server = KyuubiServer.startServer(conf)
super.beforeAll()
}
override def afterAll(): Unit = {
+ server.frontendServices.foreach {
+ case frontend: AbstractFrontendService =>
+ val sessionManager = frontend.be.sessionManager.asInstanceOf[KyuubiSessionManager]
+ sessionManager.allSessions().foreach { session =>
+ logger.warn(s"found unclosed session ${session.handle}.")
+ sessionManager.closeSession(session.handle)
Review Comment:
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928532860
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -36,7 +40,7 @@ trait WithKyuubiServer extends KyuubiFunSuite {
protected var server: KyuubiServer = _
override def beforeAll(): Unit = {
- conf.set(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
+ conf.setIfMissing(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
Review Comment:
this is why the k8s integration tests hang. cc @turboFei
<details>
<summary>logs</summary>
```
17:28:35.138 INFO org.apache.kyuubi.session.KyuubiBatchSessionImpl: There are still remaining metadata store requests for batch[8b2bce8d-69a9-4284-9cfd-ee9c140721d8]
17:28:35.268 INFO org.apache.kyuubi.server.metadata.MetadataManager: Retrying metadata requests for 8b2bce8d-69a9-4284-9cfd-ee9c140721d8
17:28:35.269 ERROR org.apache.kyuubi.server.metadata.MetadataManager: Error retrying metadata requests for 8b2bce8d-69a9-4284-9cfd-ee9c140721d8
org.apache.kyuubi.KyuubiException: Error executing
INSERT INTO metadata(
identifier,
session_type,
real_user,
user_name,
ip_address,
kyuubi_instance,
state,
resource,
class_name,
request_name,
request_conf,
request_args,
create_time,
engine_type,
cluster_manager
)
VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
:Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:372) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$insertMetadata$1(JDBCMetadataStore.scala:151) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$insertMetadata$1$adapted(JDBCMetadataStore.scala:133) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withConnection(JDBCMetadataStore.scala:445) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.insertMetadata(JDBCMetadataStore.scala:133) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.MetadataManager.insertMetadata(MetadataManager.scala:81) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.MetadataManager$$anon$1$$anon$2.run(MetadataManager.scala:225) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: java.sql.SQLIntegrityConstraintViolationException: Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:369) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 11 more
Caused by: org.apache.derby.iapi.error.StandardException: Column 'KYUUBI_INSTANCE' cannot accept a NULL value.
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeColumn(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeRow(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.InsertResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.executeStmt(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.execute(JDBCMetadataStore.scala:369) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 11 more
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#issuecomment-1193130760
```
BatchesResourceSuite:
- open batch session
- get batch session list
- negative request
- batch sessions recovery
- get local log internal redirection
- delete batch internal redirection
- support to get the real client ip for http proxy use case
- expose the metrics with operation type and current state *** FAILED ***
1 did not equal 0 (BatchesResourceSuite.scala:633)
```
the failed ut is a known issue #3114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928454985
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -52,13 +54,23 @@ trait WithKyuubiServer extends KyuubiFunSuite {
conf.set("spark.ui.enabled", "false")
conf.setIfMissing("spark.sql.catalogImplementation", "in-memory")
+ conf.setIfMissing("kyuubi.ha.zookeeper.connection.retry.policy", "ONE_TIME")
conf.setIfMissing(ENGINE_CHECK_INTERVAL, 1000L)
conf.setIfMissing(ENGINE_IDLE_TIMEOUT, 5000L)
server = KyuubiServer.startServer(conf)
super.beforeAll()
}
override def afterAll(): Unit = {
+ server.frontendServices.foreach {
+ case frontend: AbstractFrontendService =>
+ val sessionManager = frontend.be.sessionManager.asInstanceOf[KyuubiSessionManager]
+ sessionManager.allSessions().foreach { session =>
+ logger.warn(s"found unclosed session ${session.handle}.")
+ sessionManager.closeSession(session.handle)
Review Comment:
`closeSession` seems to throw exceptions in some cases, is it better to add a try catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3121: [CI] Fix GA oom issue
URL: https://github.com/apache/incubator-kyuubi/pull/3121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928534449
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -36,7 +40,7 @@ trait WithKyuubiServer extends KyuubiFunSuite {
protected var server: KyuubiServer = _
override def beforeAll(): Unit = {
- conf.set(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
+ conf.setIfMissing(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
Review Comment:
another issue occurs after this one is fixed.
```
07:00:28.229 ERROR org.apache.kyuubi.server.metadata.MetadataManager: Error updating metadata for session 6654226d-c108-4669-98aa-f2c9535de379
org.apache.kyuubi.KyuubiException: A truncation error was encountered trying to shrink VARCHAR ' org.apache.spark.deploy.SparkSubmit --conf spark.kubernetes&' to length 1024.
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withUpdateCount(JDBCMetadataStore.scala:417) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$updateMetadata$7(JDBCMetadataStore.scala:274) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.$anonfun$updateMetadata$7$adapted(JDBCMetadataStore.scala:273) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withConnection(JDBCMetadataStore.scala:445) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.updateMetadata(JDBCMetadataStore.scala:273) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.server.metadata.MetadataManager.updateMetadata(MetadataManager.scala:143) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.session.KyuubiSessionManager.updateMetadata(KyuubiSessionManager.scala:173) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.operation.BatchJobSubmission.updateBatchMetadata(BatchJobSubmission.scala:131) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.operation.BatchJobSubmission.submitAndMonitorBatchJob(BatchJobSubmission.scala:205) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at org.apache.kyuubi.operation.BatchJobSubmission.$anonfun$runInternal$7(BatchJobSubmission.scala:173) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23) ~[scala-library-2.12.15.jar:?]
at scala.Option.getOrElse(Option.scala:189) ~[scala-library-2.12.15.jar:?]
at org.apache.kyuubi.operation.BatchJobSubmission.$anonfun$runInternal$2(BatchJobSubmission.scala:173) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: java.sql.SQLDataException: A truncation error was encountered trying to shrink VARCHAR ' org.apache.spark.deploy.SparkSubmit --conf spark.kubernetes&' to length 1024.
at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeLargeUpdate(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withUpdateCount(JDBCMetadataStore.scala:414) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 17 more
Caused by: org.apache.derby.iapi.error.StandardException: A truncation error was encountered trying to shrink VARCHAR ' org.apache.spark.deploy.SparkSubmit --conf spark.kubernetes&' to length 1024.
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.types.SQLChar.hasNonBlankChars(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.types.SQLVarchar.normalize(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.types.SQLVarchar.normalize(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.iapi.types.DataTypeDescriptor.normalize(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeColumn(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeRow(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.UpdateResultSet.getNextRowCore(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.UpdateResultSet.collectAffectedRows(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.execute.UpdateResultSet.open(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.executeStmt(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeLargeUpdate(Unknown Source) ~[derby-10.14.2.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(Unknown Source) ~[derby-10.14.2.0.jar:?]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61) ~[HikariCP-4.0.3.jar:?]
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java) ~[HikariCP-4.0.3.jar:?]
at org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore.withUpdateCount(JDBCMetadataStore.scala:414) ~[kyuubi-server_2.12-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT]
... 17 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#issuecomment-1193774348
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#issuecomment-1193133730
```
22/07/23 07:00:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:01:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:02:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:03:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:04:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:05:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:06:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:07:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:08:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:09:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:10:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:11:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:12:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:13:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:14:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:15:20 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
22/07/23 07:16:23 INFO EngineServiceDiscovery: 2 connection(s) are active, delay shutdown
```
The unclosed sessions may block the leaked engine. In fact, these sessions should be closed by the `FeTServerEventHandler`, but I can't figure out the root cause, This PR closes these sessions after each Suite to prevent engine leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#issuecomment-1193128961
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3121](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6df03e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/5c1ea6e5daf1069b4add344a5cd64459e67966d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c1ea6e) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3121 +/- ##
============================================
- Coverage 51.33% 51.31% -0.02%
Complexity 6 6
============================================
Files 458 458
Lines 25388 25388
Branches 3536 3536
============================================
- Hits 13033 13029 -4
+ Misses 11116 11115 -1
- Partials 1239 1244 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `83.33% <0.00%> (-12.50%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `68.91% <0.00%> (-1.36%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `75.23% <0.00%> (-0.96%)` | :arrow_down: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `77.63% <0.00%> (ø)` | |
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `82.35% <0.00%> (+2.94%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3121: [CI] Fix GA oom issue
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on code in PR #3121:
URL: https://github.com/apache/incubator-kyuubi/pull/3121#discussion_r928532860
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/WithKyuubiServer.scala:
##########
@@ -36,7 +40,7 @@ trait WithKyuubiServer extends KyuubiFunSuite {
protected var server: KyuubiServer = _
override def beforeAll(): Unit = {
- conf.set(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
+ conf.setIfMissing(FRONTEND_PROTOCOLS, frontendProtocols.map(_.toString))
Review Comment:
this is why the k8s integration tests hang. cc @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org