[GitHub] incubator-geode pull request #149: GEODE-1331: gfsh.bat on Windows is incorr...

[jinmeiliao <gi...@git.apache.org>]

Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/149#discussion_r65780743
  
    --- Diff: geode-assembly/src/main/dist/bin/gfsh.bat ---
    @@ -74,14 +70,14 @@ REM )
     REM  Consider java is from JDK
     @set TOOLS_JAR=%JAVA_HOME%\lib\tools.jar
     @IF EXIST "%TOOLS_JAR%" (
    -    @set CLASSPATH=%CLASSPATH%;%TOOLS_JAR%
    +    @set DEPENDENCIES=%DEPENDENCIES%;%TOOLS_JAR%
     ) ELSE (
         set TOOLS_JAR=
     )
     
     @set LAUNCHER=com.gemstone.gemfire.management.internal.cli.Launcher
     @if defined JAVA_ARGS (
    -@set JAVA_ARGS="%JAVA_ARGS%"
    +    @set JAVA_ARGS="%JAVA_ARGS%"
     )
    -@"%GF_JAVA%" -Dgfsh=true -Dlog4j.configurationFile=classpath:log4j2-cli.xml %JAVA_ARGS% %LAUNCHER% %*
    --- End diff --
    
    I am not very good at scripting language at all, but could the problem be fixed by just adding 
     -classpath %CLASSPATH% in the final command line? 
    
    It seems that we don't need to introduce DEPENDENCIES variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---