You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 19:45:21 UTC
[GitHub] [flink] Myasuka opened a new pull request #10751: [hotfix][docs]
Fix link to latency granularity
Myasuka opened a new pull request #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751
## What is the purpose of the change
Fix the incorrect link display to latency granularity.
Before [metrics-master-url](https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#io):
<img width="391" alt="image" src="https://user-images.githubusercontent.com/1709104/71688638-2c260b80-2ddb-11ea-9e07-5578445be81e.png">
After:
<img width="382" alt="image" src="https://user-images.githubusercontent.com/1709104/71688656-33e5b000-2ddb-11ea-9196-e1b792b799c7.png">
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10751: [hotfix][docs] Fix link
to latency granularity
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751#issuecomment-570321659
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 15c42875ee5873b6f87d9a24ec9a724da6349de0 (Thu Jan 02 19:49:06 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on issue #10751: [hotfix][docs] Fix link
to latency granularity
Posted by GitBox <gi...@apache.org>.
Myasuka commented on issue #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751#issuecomment-570322069
@wuchong , this hotfix is for master branch and https://github.com/apache/flink/pull/10752 is for release-1.10 branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10751: [hotfix][docs]
Fix link to latency granularity
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751#issuecomment-570336126
<!--
Meta data
Hash:15c42875ee5873b6f87d9a24ec9a724da6349de0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142917795 TriggerType:PUSH TriggerID:15c42875ee5873b6f87d9a24ec9a724da6349de0
Hash:15c42875ee5873b6f87d9a24ec9a724da6349de0 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4051 TriggerType:PUSH TriggerID:15c42875ee5873b6f87d9a24ec9a724da6349de0
-->
## CI report:
* 15c42875ee5873b6f87d9a24ec9a724da6349de0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142917795) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10751: [hotfix][docs] Fix link
to latency granularity
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10751: [hotfix][docs]
Fix link to latency granularity
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751#issuecomment-570336126
<!--
Meta data
Hash:15c42875ee5873b6f87d9a24ec9a724da6349de0 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142917795 TriggerType:PUSH TriggerID:15c42875ee5873b6f87d9a24ec9a724da6349de0
Hash:15c42875ee5873b6f87d9a24ec9a724da6349de0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4051 TriggerType:PUSH TriggerID:15c42875ee5873b6f87d9a24ec9a724da6349de0
-->
## CI report:
* 15c42875ee5873b6f87d9a24ec9a724da6349de0 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142917795) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10751: [hotfix][docs] Fix link
to latency granularity
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10751: [hotfix][docs] Fix link to latency granularity
URL: https://github.com/apache/flink/pull/10751#issuecomment-570336126
<!--
Meta data
Hash:15c42875ee5873b6f87d9a24ec9a724da6349de0 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:15c42875ee5873b6f87d9a24ec9a724da6349de0
-->
## CI report:
* 15c42875ee5873b6f87d9a24ec9a724da6349de0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services