You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Indhumathi27 <gi...@git.apache.org> on 2018/07/27 18:12:28 UTC
[GitHub] carbondata pull request #2573: [CARBONDATA-2794]Distinct count fails on Arra...
GitHub user Indhumathi27 opened a pull request:
https://github.com/apache/carbondata/pull/2573
[CARBONDATA-2794]Distinct count fails on ArrayOfStruct
This PR fixes Code Generator Error thrown when Select filter contains more than one count of distinct of ArrayofStruct with group by Clause
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
Testcase added
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Indhumathi27/carbondata codegeb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2573
----
commit e9e1cd6e7fcd9603bc35a74ad7981853502fef51
Author: Indhumathi27 <in...@...>
Date: 2018-07-27T18:09:50Z
[CARBONDATA-2794]Distinct count fails on ArrayOfStruct
----
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2573
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6044/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7578/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6338/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7583/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7585/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:
https://github.com/apache/carbondata/pull/2573
Retest this please
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2573
LGTM
---
[GitHub] carbondata pull request #2573: [CARBONDATA-2794]Distinct count fails on Arra...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2573#discussion_r205938933
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala ---
@@ -743,7 +743,7 @@ class CarbonLateDecodeRule extends Rule[LogicalPlan] with PredicateHelper {
attrName.contains(n)
})
case ar : ArrayType =>
- attrName.contains(a.name + "[")
+ attrName.contains(a.name + "[") || ar.elementType.isInstanceOf[StructType]
--- End diff --
Don't check on the outut,
Add as below to check the child types also.
`attrName.contains(a.name + "[") || attrName.contains(a.name + ".")`
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6333/
---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2573
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6340/
---
[GitHub] carbondata pull request #2573: [CARBONDATA-2794]Distinct count fails on Arra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2573
---