[GitHub] [beam] Amraneze commented on pull request #24973: [#24971] Add a retry policy for JmsIO #24971

["Amraneze (via GitHub)" <gi...@apache.org>]

Amraneze commented on PR #24973:
URL: https://github.com/apache/beam/pull/24973#issuecomment-1418270551

   Hello @Abacn, Sorry I was busy with work. I redesigned the flow of `JmsIOWriter`. I tried to create a cache and flush all the messages in `finishBundle` but we will need to handle the exception in `processElement` otherwise the DoFn will tear down without calling `finishBundle`. I added a new step which will be used only for processing failed published messages and also I added a condition whenever the producer needs to be recreated it. Let me know what do you think and if is there any tests to add ?
   >PS: Should I add a benchmark test ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org