You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2018/10/24 04:25:07 UTC

[GitHub] [incubator-dubbo] chickenlj opened pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

## What is the purpose of the change
Fix problem reported in https://github.com/apache/incubator-skywalking/issues/1769

## Brief changelog

* Add Inject annotation
* Printing log instead of throwing Exception in SpringExtensionFactory

## Verifying this change

ExtensionLoaderTest.testInjectExtension

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=h1) Report
> Merging [#2681](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/a531a5cb9ace8f06a6192d65756d828ab8767f47?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `57.14%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2681      +/-   ##
============================================
+ Coverage     47.38%   47.42%   +0.04%     
+ Complexity     4297     4292       -5     
============================================
  Files           557      553       -4     
  Lines         24384    24364      -20     
  Branches       4313     4308       -5     
============================================
+ Hits          11554    11555       +1     
+ Misses        11044    11028      -16     
+ Partials       1786     1781       -5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `72.59% <100%> (+0.11%)` | `117 <0> (+1)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `68.96% <40%> (-15.65%)` | `8 <0> (ø)` | |
| [...baba/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3V0aWwvQW5ub3RhdGlvblV0aWxzLmphdmE=) | `42.1% <0%> (-19.01%)` | `4% <0%> (-5%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...va/com/alibaba/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0NvbmZpZ1V0aWxzLmphdmE=) | `71.42% <0%> (-0.3%)` | `45% <0%> (+1%)` | |
| [...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==) | `22.22% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...ntext/annotation/DubboConfigBindingsRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdzUmVnaXN0cmFyLmphdmE=) | `100% <0%> (ø)` | `4% <0%> (ø)` | :arrow_down: |
| [.../config/spring/status/DataSourceStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3N0YXR1cy9EYXRhU291cmNlU3RhdHVzQ2hlY2tlci5qYXZh) | `76.47% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...nnotation/DubboConfigBindingBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdCZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `67.5% <0%> (ø)` | `7% <0%> (ø)` | :arrow_down: |
| [...ans/factory/annotation/ServiceBeanNameBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQmVhbk5hbWVCdWlsZGVyLmphdmE=) | `100% <0%> (ø)` | `12% <0%> (ø)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=footer). Last update [a531a5c...d1a45ad](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=h1) Report
> Merging [#2681](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/a531a5cb9ace8f06a6192d65756d828ab8767f47?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `62.5%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2681      +/-   ##
============================================
- Coverage     47.38%   47.36%   -0.02%     
  Complexity     4297     4297              
============================================
  Files           557      557              
  Lines         24384    24390       +6     
  Branches       4313     4315       +2     
============================================
- Hits          11554    11553       -1     
- Misses        11044    11048       +4     
- Partials       1786     1789       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `79.31% <60%> (-5.31%)` | `8 <0> (ø)` | |
| [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `72.44% <66.66%> (-0.04%)` | `117 <0> (+1)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-11.12%)` | `5% <0%> (-2%)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlci5qYXZh) | `72.13% <0%> (-3.28%)` | `9% <0%> (-1%)` | |
| [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `59.37% <0%> (+1.56%)` | `9% <0%> (+1%)` | :arrow_up: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `57.83% <0%> (+3.61%)` | `15% <0%> (+2%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=footer). Last update [a531a5c...f8d0427](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
I think an marker annotation should work fine, no need to introduce `disable`. what do you think?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
Changed to `@DisableInject`.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=h1) Report
> Merging [#2681](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/a531a5cb9ace8f06a6192d65756d828ab8767f47?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `62.5%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2681      +/-   ##
============================================
+ Coverage     47.38%   47.41%   +0.02%     
+ Complexity     4297     4290       -7     
============================================
  Files           557      553       -4     
  Lines         24384    24365      -19     
  Branches       4313     4308       -5     
============================================
- Hits          11554    11552       -2     
+ Misses        11044    11029      -15     
+ Partials       1786     1784       -2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `79.31% <60%> (-5.31%)` | `8 <0> (ø)` | |
| [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `72.44% <66.66%> (-0.04%)` | `117 <0> (+1)` | |
| [...baba/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3V0aWwvQW5ub3RhdGlvblV0aWxzLmphdmE=) | `42.1% <0%> (-19.01%)` | `4% <0%> (-5%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...va/com/alibaba/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0NvbmZpZ1V0aWxzLmphdmE=) | `71.42% <0%> (-0.3%)` | `45% <0%> (+1%)` | |
| [...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==) | `22.22% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...ntext/annotation/DubboConfigBindingsRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdzUmVnaXN0cmFyLmphdmE=) | `100% <0%> (ø)` | `4% <0%> (ø)` | :arrow_down: |
| [.../config/spring/status/DataSourceStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3N0YXR1cy9EYXRhU291cmNlU3RhdHVzQ2hlY2tlci5qYXZh) | `76.47% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...nnotation/DubboConfigBindingBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdCZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `67.5% <0%> (ø)` | `7% <0%> (ø)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=footer). Last update [a531a5c...68424c0](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
Since Dubbo's default behavior is always injecting on setter, why don't we name this annotation as `@DisableInject`?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
Good point, `disable` removed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on pull request #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "htynkn (GitHub)" <gi...@apache.org>.
should it be `autoInject`?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2681: [Dubbo-2678] Add ability to turn off SPI auto injection, special support for Object type.

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=h1) Report
> Merging [#2681](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/a531a5cb9ace8f06a6192d65756d828ab8767f47?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `62.5%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2681      +/-   ##
============================================
+ Coverage     47.38%   47.41%   +0.02%     
+ Complexity     4297     4290       -7     
============================================
  Files           557      553       -4     
  Lines         24384    24365      -19     
  Branches       4313     4308       -5     
============================================
- Hits          11554    11552       -2     
+ Misses        11044    11029      -15     
+ Partials       1786     1784       -2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `79.31% <60%> (-5.31%)` | `8 <0> (ø)` | |
| [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `72.44% <66.66%> (-0.04%)` | `117 <0> (+1)` | |
| [...baba/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3V0aWwvQW5ub3RhdGlvblV0aWxzLmphdmE=) | `42.1% <0%> (-19.01%)` | `4% <0%> (-5%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...va/com/alibaba/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0NvbmZpZ1V0aWxzLmphdmE=) | `71.42% <0%> (-0.3%)` | `45% <0%> (+1%)` | |
| [...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==) | `22.22% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...ntext/annotation/DubboConfigBindingsRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdzUmVnaXN0cmFyLmphdmE=) | `100% <0%> (ø)` | `4% <0%> (ø)` | :arrow_down: |
| [.../config/spring/status/DataSourceStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3N0YXR1cy9EYXRhU291cmNlU3RhdHVzQ2hlY2tlci5qYXZh) | `76.47% <0%> (ø)` | `6% <0%> (ø)` | :arrow_down: |
| [...nnotation/DubboConfigBindingBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0JpbmRpbmdCZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `67.5% <0%> (ø)` | `7% <0%> (ø)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2681/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=footer). Last update [a531a5c...68424c0](https://codecov.io/gh/apache/incubator-dubbo/pull/2681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2681 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org