[jira] [Commented] (FLINK-3730) Fix RocksDB Local Directory Initialization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236856#comment-15236856 ] 

ASF GitHub Bot commented on FLINK-3730:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1873

    [FLINK-3730] Fix RocksDB Local Directory Initialization

    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink rocksdb-fix-dir-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1873
    
----
commit bfef1932465cbf279b69eefbc724128fe79cece8
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-04-12T08:46:59Z

    [FLINK-3730] Fix RocksDB Local Directory Initialization

----


> Fix RocksDB Local Directory Initialization
> ------------------------------------------
>
>                 Key: FLINK-3730
>                 URL: https://issues.apache.org/jira/browse/FLINK-3730
>             Project: Flink
>          Issue Type: Bug
>          Components: state backends, Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> The test that checks whether a directory is viable is not correct and the tests in `RocksDBStateBackendConfigTest` fail to catch them: `testFailWhenNoLocalStorageDir()` and `testContinueOnSomeDbDirectoriesMissing()`
> The problem is that the backend tests whether the dir exists or can be created. The tests create the directory and set it to non-writable. This means that the check accepts these. The job would only fail later when actually trying to create a directory in the initialized data directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)