[GitHub] [airflow] eladkal commented on a diff in pull request #27947: refactored Amazon Redshift-data functionality into the hook

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #27947:
URL: https://github.com/apache/airflow/pull/27947#discussion_r1104839542


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -46,3 +48,73 @@ class RedshiftDataHook(AwsGenericHook["RedshiftDataAPIServiceClient"]):
     def __init__(self, *args, **kwargs) -> None:
         kwargs["client_type"] = "redshift-data"
         super().__init__(*args, **kwargs)
+
+    def execute_query(
+        self,
+        database: str,
+        sql: str | list[str],
+        cluster_identifier: str | None = None,
+        db_user: str | None = None,
+        parameters: list | None = None,
+        secret_arn: str | None = None,
+        statement_name: str | None = None,
+        with_event: bool = False,
+        await_result: bool = True,

Review Comment:
   Yes please lets rename. better to stay consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org