You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Mulavar (via GitHub)" <gi...@apache.org> on 2023/04/03 08:05:26 UTC
[GitHub] [hudi] Mulavar opened a new pull request, #8363: [HUDI-6022]Remove redundant method param of BaseFlinkCommitActionExec…
Mulavar opened a new pull request, #8363:
URL: https://github.com/apache/hudi/pull/8363
…utor
### Change Logs
We have stored the `instantTime` in the superclass BaseActionExector, and there's no need to keep a method param 'instantTime`, it's preferred to remove it to make code cleaner.
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
Make code cleaner.
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
Low
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
None.
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8363: [HUDI-6022]Remove redundant method param of BaseFlinkCommitActionExec…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8363:
URL: https://github.com/apache/hudi/pull/8363#issuecomment-1493943898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90bda788124f355c57fba44f469b94f3a9968af9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16089",
"triggerID" : "90bda788124f355c57fba44f469b94f3a9968af9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90bda788124f355c57fba44f469b94f3a9968af9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8363: [HUDI-6022]Remove redundant method param of BaseFlinkCommitActionExec…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8363:
URL: https://github.com/apache/hudi/pull/8363#issuecomment-1493931465
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90bda788124f355c57fba44f469b94f3a9968af9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90bda788124f355c57fba44f469b94f3a9968af9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90bda788124f355c57fba44f469b94f3a9968af9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8363: [HUDI-6022] Remove redundant method param of BaseFlinkCommitActionExec…
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8363:
URL: https://github.com/apache/hudi/pull/8363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8363: [HUDI-6022]Remove redundant method param of BaseFlinkCommitActionExec…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8363:
URL: https://github.com/apache/hudi/pull/8363#issuecomment-1494655381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90bda788124f355c57fba44f469b94f3a9968af9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16089",
"triggerID" : "90bda788124f355c57fba44f469b94f3a9968af9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90bda788124f355c57fba44f469b94f3a9968af9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org