[GitHub] [netbeans] matthiasblaesing commented on pull request #4882: Retain SOURCE annotations inside the internal model.

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #4882:
URL: https://github.com/apache/netbeans/pull/4882#issuecomment-1481874953

   @jlahoda same question as before: this is reviewed, should this be merged? The conflict is trivial:
   
   ```
   <<<<<<< HEAD
           NBLog.preRegister(context, DEV_NULL);
   =======
           NBLog.preRegister(context, OUT);
   >>>>>>> 8de3e6521dc3 (Retain SOURCE annotations inside the intenal model.)
   ``
   
   If I read this correctly, your change pipes the logging to stderr, while another drops output, so that can be trivially fixed. If don't have the time, say so and I'll fix it and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists