[GitHub] [iceberg] rdblue commented on a diff in pull request #6358: AWS: Print logs whether Glue optimistic locking is used or not

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6358:
URL: https://github.com/apache/iceberg/pull/6358#discussion_r1051686720


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -315,7 +315,12 @@ void persistGlueTable(Table glueTable, Map<String, String> parameters, TableMeta
                       .build());
       // Use Optimistic locking with table version id while updating table
       if (!SET_VERSION_ID.isNoop() && lockManager == null) {
+        LOG.debug("Using optimistic locking with table version: {}", glueTable.versionId());

Review Comment:
   Configuration should be logged once, not every time it is used. Can you fix this to log what you want to when the catalog is initialized?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org