You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/04/10 10:50:27 UTC

Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/
-----------------------------------------------------------

(Updated April 10, 2013, 8:50 a.m.)


Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.


Changes
-------

added cloudstack and Devdeep


Description
-------

Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 


Diffs
-----

  plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 

Diff: https://reviews.apache.org/r/10392/diff/


Testing
-------

tested manually


Thanks,

Anshul Gangwar


Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

Posted by Devdeep Singh <de...@citrix.com>.

> On April 10, 2013, 9:18 a.m., Devdeep Singh wrote:
> > Ship It!

Looks good. Someone with appropriate rights needs to pick up the patch and apply it on master.


- Devdeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/#review18941
-----------------------------------------------------------


On April 10, 2013, 8:53 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10392/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1993.
> 
> 
> Diffs
> -----
> 
>   plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 
> 
> Diff: https://reviews.apache.org/r/10392/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/#review18941
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On April 10, 2013, 8:53 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10392/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1993.
> 
> 
> Diffs
> -----
> 
>   plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 
> 
> Diff: https://reviews.apache.org/r/10392/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

> On April 12, 2013, 7:28 a.m., Sateesh Chodapuneedi wrote:
> > Ship It!


Committed the patch to master branch.
commit 7fb63be6e1c2ed2b6d2de02dae3ec0f77f1748f3


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/#review19054
-----------------------------------------------------------


On April 10, 2013, 8:53 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10392/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1993.
> 
> 
> Diffs
> -----
> 
>   plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 
> 
> Diff: https://reviews.apache.org/r/10392/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/#review19054
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On April 10, 2013, 8:53 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10392/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1993.
> 
> 
> Diffs
> -----
> 
>   plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 
> 
> Diff: https://reviews.apache.org/r/10392/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request: Syslog messages not getting generated for the "alertType:: 0"

Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10392/
-----------------------------------------------------------

(Updated April 10, 2013, 8:53 a.m.)


Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Sateesh Chodapuneedi.


Changes
-------

added bug no


Description
-------

Fixed the issue Syslog messages not getting generated for the "alertType:: 0  ------ System Alert: Low Available Memory in cluster" 


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1993.


Diffs
-----

  plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java d2f2565 

Diff: https://reviews.apache.org/r/10392/diff/


Testing
-------

tested manually


Thanks,

Anshul Gangwar