You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jfrazee <gi...@git.apache.org> on 2016/11/19 21:55:36 UTC
[GitHub] nifi pull request #1250: NIFI-3061 PutAzureEventHub blocks after network int...
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1250
NIFI-3061 PutAzureEventHub blocks after network interruption
This change maintains status quo and does not enable the existing unit tests. The change was tested against [NIFI-3061.xml](https://gist.github.com/jfrazee/6820ec854974df88519f99b3388a0874) though. As mentioned in [NIFI-3070](https://issues.apache.org/jira/browse/NIFI-3070), there isn't a good way to provide meaningful unit tests so integration tests should be added as a new improvement.
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-3061
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1250
----
commit e67548fb804fbfd35dcd77886d47a0c38e0353c0
Author: Joey Frazee <jo...@icloud.com>
Date: 2016-11-19T21:25:19Z
Bumped azure-eventhubs version to 0.9.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1250: NIFI-3061 PutAzureEventHub blocks after network interrupti...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1250
I've confirmed the upgrade works without problem using my Azure environment. +1, merged into master.
I agree with the idea of improving integration test. Thank you, @jfrazee !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1250: NIFI-3061 PutAzureEventHub blocks after network interrupti...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1250
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1250: NIFI-3061 PutAzureEventHub blocks after network int...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---