You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "y0psolo (via GitHub)" <gi...@apache.org> on 2023/08/31 16:56:13 UTC

[GitHub] [iceberg-rust] y0psolo opened a new issue, #52: No builder for TableMetadata and no public field

y0psolo opened a new issue, #52:
URL: https://github.com/apache/iceberg-rust/issues/52

   There is no way to create a new TableMetadata struct outside a deserialization operation. I don't know if it's intended but all other struct have either builder or public field.
   
   By the way i dont see clearly a consistent way of building API struct. Sometimes there is a builder and no public field, sometimes public field and no builder and sometimes builder and public field.
   
   To have a better visibility on this I could write, if you want, a short table summary if needed with all API struct and two column : pub  field (yes/no), builder (yes/no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] No builder for TableMetadata and no public field [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #52: No builder for TableMetadata and no public field
URL: https://github.com/apache/iceberg-rust/issues/52


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] y0psolo commented on issue #52: No builder for TableMetadata and no public field

Posted by "y0psolo (via GitHub)" <gi...@apache.org>.
y0psolo commented on issue #52:
URL: https://github.com/apache/iceberg-rust/issues/52#issuecomment-1717835540

   i will try to start working on it next week. Not too much spare time till now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] liurenjie1024 commented on issue #52: No builder for TableMetadata and no public field

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #52:
URL: https://github.com/apache/iceberg-rust/issues/52#issuecomment-1702017174

   Hi, @y0psolo Thanks for the contribution. We had a discussion in #3 about the style of public api, in conclusion
   1. For complex structs such as TableMetadata, Sanpshot, Schema, etc, we prefer not to expose pub field, but only necessary methods
   2. I'm ok with builder pattern.
   
   cc @Xuanwo @ZENOTME @JanKaul Any comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] No builder for TableMetadata and no public field [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #52:
URL: https://github.com/apache/iceberg-rust/issues/52#issuecomment-2503873866

   Now https://github.com/apache/iceberg-rust/pull/587 is in, I'll go ahead and close this issue 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] JanKaul commented on issue #52: No builder for TableMetadata and no public field

Posted by "JanKaul (via GitHub)" <gi...@apache.org>.
JanKaul commented on issue #52:
URL: https://github.com/apache/iceberg-rust/issues/52#issuecomment-1711180269

   I would also be in favor of using the builder pattern for the pub structs.
   
   If I'm correct all pub structs except for TableMetadata already have a builder. With the `derive_builder` crate it should be quite easy to implement the buider for TableMetadata.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org