[GitHub] [accumulo] keith-turner edited a comment on issue #680: Add method to created conditional writer that takes no config.

[GitBox <gi...@apache.org>]

keith-turner edited a comment on issue #680:
URL: https://github.com/apache/accumulo/issues/680#issuecomment-845233108


   >  I'm still not sure about changing the defaults via client properties though.
   
   I was thinking the client prop behavior should be consistent w/ the other methods. Looking into it, the method w/o a config object is completely unrelated to client config override for createBatchWriter() methods.  For example the following will merge in client config for batch writer for either of the createBatchWriter methods.
   
   https://github.com/apache/accumulo/blob/af2d2d630094fc06e0ac1d6702a9a49d30ec1e94/core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java#L535
   
   I think when I wrote the ticket I was thinking they are related.  They are not related from an impl standpoint.  I think the only relation is more from a usability standpoint, in that the methods w/ no config obj exists to support only using client props.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org