You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Neal Richardson (Jira)" <ji...@apache.org> on 2021/09/17 19:16:00 UTC

[jira] [Commented] (ARROW-14019) [R] expect_dplyr_equal() test helper function ignores grouping

    [ https://issues.apache.org/jira/browse/ARROW-14019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416883#comment-17416883 ] 

Neal Richardson commented on ARROW-14019:
-----------------------------------------

It's because it is using {{expect_equivalent}}, which ignores attributes. I'll deal with this in ARROW-13550 (I have to in order to test that feature).

> [R] expect_dplyr_equal() test helper function ignores grouping
> --------------------------------------------------------------
>
>                 Key: ARROW-14019
>                 URL: https://issues.apache.org/jira/browse/ARROW-14019
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Nicola Crane
>            Assignee: Neal Richardson
>            Priority: Minor
>
> I'm writing bindings for `dplyr::distinct()` and I have a unit test which uses `expect_dplyr_equal()` and passes despite the result incorrectly dropping groups.
> See:
> https://github.com/apache/arrow/pull/11143/files#diff-aea5ce6c4634423c094e06eaa84000ad9b92f7ed5127f1678dc51892c54003ceR56-R63



--
This message was sent by Atlassian Jira
(v8.3.4#803005)