You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/01/26 20:53:25 UTC

[GitHub] davisp commented on a change in pull request #1129: Elixir suite davisp

davisp commented on a change in pull request #1129: Elixir suite davisp
URL: https://github.com/apache/couchdb/pull/1129#discussion_r164219459
 
 

 ##########
 File path: src/chttpd/src/chttpd_misc.erl
 ##########
 @@ -205,7 +205,14 @@ cancel_replication(PostBody, Ctx) ->
             {error, badrpc};
         Else ->
             % Unclear what to do here -- pick the first error?
-            hd(Else)
+            % Except try ignoring any {error, not_found} responses
+            % because we'll always get two of those
+            case Else -- [{error, not_found}] of
+                [] ->
 
 Review comment:
   Fair point. Fixing up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services