You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sean Sullivan (JIRA)" <ji...@apache.org> on 2007/06/05 18:43:26 UTC
[jira] Created: (WICKET-615) BookmarkablePageRequestTarget respond
method
BookmarkablePageRequestTarget respond method
--------------------------------------------
Key: WICKET-615
URL: https://issues.apache.org/jira/browse/WICKET-615
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta1
Reporter: Sean Sullivan
The respond method in BookmarkablePageRequestTarget.java contains a "FIXME" comment.
Does this need to be addressed?
if (requestCycle.getRedirect())
{
IRequestCycleProcessor processor = requestCycle.getProcessor();
// This is relative!!! FIXME: Make this absolute.
String redirectUrl = processor.getRequestCodingStrategy().encode(requestCycle, this).toString();
requestCycle.getResponse().redirect(redirectUrl);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-615) BookmarkablePageRequestTarget respond
method
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-615:
--------------------------------
Priority: Trivial (was: Major)
> BookmarkablePageRequestTarget respond method
> --------------------------------------------
>
> Key: WICKET-615
> URL: https://issues.apache.org/jira/browse/WICKET-615
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Sean Sullivan
> Assignee: Alastair Maw
> Priority: Trivial
> Fix For: 1.3.0-beta2
>
>
> The respond method in BookmarkablePageRequestTarget.java contains a "FIXME" comment.
> Does this need to be addressed?
> if (requestCycle.getRedirect())
> {
> IRequestCycleProcessor processor = requestCycle.getProcessor();
> // This is relative!!! FIXME: Make this absolute.
> String redirectUrl = processor.getRequestCodingStrategy().encode(requestCycle, this).toString();
> requestCycle.getResponse().redirect(redirectUrl);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-615) BookmarkablePageRequestTarget respond
method
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw reassigned WICKET-615:
-----------------------------------
Assignee: Alastair Maw
> BookmarkablePageRequestTarget respond method
> --------------------------------------------
>
> Key: WICKET-615
> URL: https://issues.apache.org/jira/browse/WICKET-615
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Sean Sullivan
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
>
> The respond method in BookmarkablePageRequestTarget.java contains a "FIXME" comment.
> Does this need to be addressed?
> if (requestCycle.getRedirect())
> {
> IRequestCycleProcessor processor = requestCycle.getProcessor();
> // This is relative!!! FIXME: Make this absolute.
> String redirectUrl = processor.getRequestCodingStrategy().encode(requestCycle, this).toString();
> requestCycle.getResponse().redirect(redirectUrl);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-615) BookmarkablePageRequestTarget respond
method
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-615.
---------------------------------
Resolution: Fixed
This FIXME was removed from trunk some time ago.
The servlet container makes the URL absolute.
> BookmarkablePageRequestTarget respond method
> --------------------------------------------
>
> Key: WICKET-615
> URL: https://issues.apache.org/jira/browse/WICKET-615
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Sean Sullivan
> Assignee: Alastair Maw
> Priority: Trivial
> Fix For: 1.3.0-beta2
>
>
> The respond method in BookmarkablePageRequestTarget.java contains a "FIXME" comment.
> Does this need to be addressed?
> if (requestCycle.getRedirect())
> {
> IRequestCycleProcessor processor = requestCycle.getProcessor();
> // This is relative!!! FIXME: Make this absolute.
> String redirectUrl = processor.getRequestCodingStrategy().encode(requestCycle, this).toString();
> requestCycle.getResponse().redirect(redirectUrl);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-615) BookmarkablePageRequestTarget respond
method
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-615:
--------------------------------
Fix Version/s: 1.3.0-beta2
> BookmarkablePageRequestTarget respond method
> --------------------------------------------
>
> Key: WICKET-615
> URL: https://issues.apache.org/jira/browse/WICKET-615
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Sean Sullivan
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
>
> The respond method in BookmarkablePageRequestTarget.java contains a "FIXME" comment.
> Does this need to be addressed?
> if (requestCycle.getRedirect())
> {
> IRequestCycleProcessor processor = requestCycle.getProcessor();
> // This is relative!!! FIXME: Make this absolute.
> String redirectUrl = processor.getRequestCodingStrategy().encode(requestCycle, this).toString();
> requestCycle.getResponse().redirect(redirectUrl);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.