[GitHub] nam147 opened a new issue #3747: Download Slice or Dashboard As SVG, problem reusing feature from past commit

[GitBox <gi...@apache.org>]

nam147 opened a new issue #3747: Download Slice or Dashboard As SVG, problem reusing feature from past commit
URL: https://github.com/apache/incubator-superset/issues/3747
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if any
   - [X] I have reproduced the issue with at least the latest released version of superset
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   0.20.4
   
   ### Expected results
   By deploying the branch export-by-svg ( referenced by @SalehHindi  from this post: [#2995](https://github.com/apache/incubator-superset/issues/2995)
   
   or by:
   - installing the  [d3-save-svg](https://www.npmjs.com/package/d3-save-svg) and font-awesome with npm 
   - making changes in the file ExploreActionButtons.jsx, as seen  [here](https://github.com/apache/incubator-superset/compare/master...SalehHindi:export-as-svg#diff-8cde933fa08216ab7cf478126542fb36) 
   
   I could then see a export/Download SVG button when i create a slice with D3JS
   
   ### Actual results
   
   As Admin, I can't find the button anywhere maybe i'm just not looking in the right place ? 
   
   ![pleasehelp](https://user-images.githubusercontent.com/25952644/32219057-38164a38-be2d-11e7-88ab-f7222675e004.png)
   
   
   ### Steps to reproduce
   
   By cloning the branch [export-as-svg](https://github.com/SalehHindi/superset/tree/export-as-svg) 
   installing and launching superset
   
   or by:
   - installing the  [d3-save-svg](https://www.npmjs.com/package/d3-save-svg) and font-awesome with npm 
   - making changes in the file ExploreActionButtons.jsx, as seen  [here](https://github.com/apache/incubator-superset/compare/master...SalehHindi:export-as-svg#diff-8cde933fa08216ab7cf478126542fb36) 
   
    
   If this feature can't be implemented like this, could you tell me why ? Thank you.
   Your help would be greatly appreciated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services