You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 15:31:50 UTC

[GitHub] [flink] zentol commented on a change in pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.

zentol commented on a change in pull request #14596:
URL: https://github.com/apache/flink/pull/14596#discussion_r555128994



##########
File path: flink-clients/src/test/java/org/apache/flink/client/ClientUtilsTest.java
##########
@@ -26,8 +26,15 @@
 import org.apache.flink.util.SerializedThrowable;
 import org.apache.flink.util.TestLogger;
 
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.Timeout;
+import static org.hamcrest.MatcherAssert.assertThat;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import org.hamcrest.MatcherAssert;
+import static org.junit.jupiter.api.Assertions.assertTrue;

Review comment:
       are all these imports actually necessary or was it some quick-and-dirty approach?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org