You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/09/12 02:17:14 UTC

Review Request: Change FilesProcess to use async io::read

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7047/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Description
-------

see above

also:
-removed redundant length field from the JSON
-added missing test for buffered io::read


Diffs
-----

  src/files/files.cpp 806aa35 
  src/tests/files_tests.cpp 6ef2004 
  src/webui/master/static/jquery.pailer.js edd23d9 
  third_party/libprocess/src/tests.cpp 41bf973 

Diff: https://reviews.apache.org/r/7047/diff/


Testing
-------

make check on both osx and redhat

mesos-local.sh run to verify pailer still working correctly


Thanks,

Ben Mahler

Re: Review Request: Change FilesProcess to use async io::read

Posted by Benjamin Mahler <bm...@twitter.com>.
reviewboard is not playing nice, making a new review

On Tue, Sep 11, 2012 at 5:18 PM, Ben Mahler <be...@gmail.com>wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7047/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 12:18 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> see above
>
> also:
> -removed redundant length field from the JSON
> -added missing test for buffered io::read
>
>
> Diffs (updated)
> -----
>
>   src/files/files.cpp 806aa35
>   src/tests/files_tests.cpp 6ef2004
>   src/webui/master/static/jquery.pailer.js edd23d9
>   third_party/libprocess/src/tests.cpp 41bf973
>
> Diff: https://reviews.apache.org/r/7047/diff/
>
>
> Testing
> -------
>
> make check on both osx and redhat
>
> mesos-local.sh run to verify pailer still working correctly
>
>
> Thanks,
>
> Ben Mahler
>
>

Re: Review Request: Change FilesProcess to use async io::read

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7047/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 12:18 a.m.)


Review request for mesos and Benjamin Hindman.


Description
-------

see above

also:
-removed redundant length field from the JSON
-added missing test for buffered io::read


Diffs (updated)
-----

  src/files/files.cpp 806aa35 
  src/tests/files_tests.cpp 6ef2004 
  src/webui/master/static/jquery.pailer.js edd23d9 
  third_party/libprocess/src/tests.cpp 41bf973 

Diff: https://reviews.apache.org/r/7047/diff/


Testing
-------

make check on both osx and redhat

mesos-local.sh run to verify pailer still working correctly


Thanks,

Ben Mahler

Re: Review Request: Change FilesProcess to use async io::read

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7047/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 12:17 a.m.)


Review request for mesos and Benjamin Hindman.


Description
-------

see above

also:
-removed redundant length field from the JSON
-added missing test for buffered io::read


Diffs (updated)
-----

  src/files/files.cpp 806aa35 
  src/tests/files_tests.cpp 6ef2004 
  src/webui/master/static/jquery.pailer.js edd23d9 
  third_party/libprocess/src/tests.cpp 41bf973 

Diff: https://reviews.apache.org/r/7047/diff/


Testing
-------

make check on both osx and redhat

mesos-local.sh run to verify pailer still working correctly


Thanks,

Ben Mahler

Re: Review Request: Change FilesProcess to use async io::read

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7047/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 12:17 a.m.)


Review request for mesos and Benjamin Hindman.


Description
-------

see above

also:
-removed redundant length field from the JSON
-added missing test for buffered io::read


Diffs
-----

  src/files/files.cpp 806aa35 
  src/tests/files_tests.cpp 6ef2004 
  src/webui/master/static/jquery.pailer.js edd23d9 
  third_party/libprocess/src/tests.cpp 41bf973 

Diff: https://reviews.apache.org/r/7047/diff/


Testing
-------

make check on both osx and redhat

mesos-local.sh run to verify pailer still working correctly


Thanks,

Ben Mahler