You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/04/26 11:55:10 UTC

[GitHub] carbondata pull request #2173: [CARBONDATA-2379] Support Search mode run in ...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2173#discussion_r184361813
  
    --- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java ---
    @@ -105,8 +105,6 @@ public ShutdownResponse handleShutdown(ShutdownRequest request) {
           }
         } catch (InterruptedException e) {
           throw new IOException(e);
    -    } finally {
    -      reader.close();
    --- End diff --
    
    @kumarvishal09 @ravipesala I think this close operation is needed. Can you check whether this is ok?


---